Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3433)

Unified Diff: base/trace_event/BUILD.gn

Issue 1528233002: Make base a static ibrary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/third_party/dynamic_annotations/BUILD.gn ('k') | mojo/public/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/BUILD.gn
diff --git a/base/trace_event/BUILD.gn b/base/trace_event/BUILD.gn
index 9a85be81e57c675f4c73dfa49a90cdc78ce3c7fa..475f738c3da12184a730b9a9646dcdf5dd031a17 100644
--- a/base/trace_event/BUILD.gn
+++ b/base/trace_event/BUILD.gn
@@ -2,7 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-source_set("trace_event") {
+# Should be static library, see documentation on //base:base for discussion.
+static_library("trace_event") {
sources = [
"common/trace_event_common.h",
"heap_profiler_allocation_context.cc",
« no previous file with comments | « base/third_party/dynamic_annotations/BUILD.gn ('k') | mojo/public/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698