Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 15140003: Add support for split Public Suffix List distinctions. (Closed)

Created:
7 years, 7 months ago by nyquist
Modified:
7 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jam, creis+watch_chromium.org, shishir+watch_chromium.org, grt+watch_chromium.org, amit, ajwong+watch_chromium.org, browser-components-watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, robertshield, darin-cc_chromium.org, erikwright (departed), chromium-apps-reviews_chromium.org, markusheintz_, James Su
Visibility:
Public.

Description

Add support for split Public Suffix List distinctions. This adds support for the private additions to the Public Suffix List. * Since net::RegistryControlledDomainService only contained static methods, this CL changes these methods to be contained within the namespace net::registry_controlled_domains and removes the class entirely. * All methods defined as part of net::registry_controlled_domains now have a mandatory argument to specify whether the private registries should be included. * Since the old implementation did not take into account the private registries, this sets all old callers to use EXCLUDE_PRIVATE as the net::registry_controlled_domains::PrivateRegistryFilter argument. * Changes the parameter for including unknown registries or not to be an enum instead of a boolean, using a similar naming scheme as for the private registries: net::registry_controlled_domains::UnknownRegistryFilter. * This also updates the effective-TLD data file to: 45cfff9c781f 2013-04-23 11:51 +0100 It includes changes from a number of Mozilla bugs, listed on https://hg.mozilla.org/mozilla-central/log/45cfff9c781f/netwerk/dns/effective_tld_names.dat between 290afd57d2a8 (2012-07-04 16:08 +0100) and 45cfff9c781f (2013-04-23 11:51 +0100). Patch set 1 is equal to the committed patch set from: https://codereview.chromium.org/13979002/ TBRing OWNERs from original CL. TBR=pam@chromium.org BUG=37436, 96086 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200066

Patch Set 1 #

Patch Set 2 : Fixed static_cast for tld_cleanup_util.cc #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased again #

Patch Set 5 : Rebased again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7318 lines, -6522 lines) Patch
M chrome/browser/autocomplete/autocomplete_input.cc View 1 2 3 4 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/local_shared_objects_container.cc View 1 2 3 4 8 chunks +23 lines, -24 lines 0 comments Download
M chrome/browser/google/google_util.cc View 1 2 3 4 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/intranet_redirect_detector.cc View 1 2 3 4 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/net/url_fixer_upper.cc View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/predictors/logged_in_predictor_table.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/ui_manager.cc View 1 2 3 4 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/omnibox/alternate_nav_url_fetcher.cc View 1 2 3 4 1 chunk +11 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/web_contents_modal_dialog_manager.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc View 1 2 3 4 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M chrome_frame/ready_mode/ready_mode.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/net/sqlite_persistent_cookie_store.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/site_instance_impl.cc View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
M net/base/registry_controlled_domains/effective_tld_names.dat View 1 2 3 4 16 chunks +231 lines, -62 lines 0 comments Download
M net/base/registry_controlled_domains/effective_tld_names.gperf View 1 2 3 4 2 chunks +6105 lines, -5651 lines 0 comments Download
M net/base/registry_controlled_domains/effective_tld_names_unittest1.cc View 1 2 3 4 4 chunks +50 lines, -43 lines 0 comments Download
M net/base/registry_controlled_domains/effective_tld_names_unittest1.gperf View 1 2 3 4 1 chunk +12 lines, -8 lines 0 comments Download
M net/base/registry_controlled_domains/effective_tld_names_unittest2.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/registry_controlled_domains/effective_tld_names_unittest2.gperf View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M net/base/registry_controlled_domains/registry_controlled_domain.h View 1 2 3 4 1 chunk +106 lines, -86 lines 0 comments Download
M net/base/registry_controlled_domains/registry_controlled_domain.cc View 1 2 3 4 3 chunks +119 lines, -113 lines 0 comments Download
M net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc View 1 2 3 4 3 chunks +200 lines, -81 lines 0 comments Download
M net/base/sdch_manager.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M net/base/static_cookie_policy.cc View 1 2 3 4 2 chunks +10 lines, -4 lines 0 comments Download
M net/cookies/cookie_monster.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M net/cookies/cookie_util.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M net/net.gyp View 1 2 3 4 4 chunks +3 lines, -2 lines 0 comments Download
M net/ssl/server_bound_cert_service.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/tld_cleanup/README View 1 2 3 4 1 chunk +12 lines, -3 lines 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.cc View 1 2 3 4 2 chunks +7 lines, -231 lines 0 comments Download
M net/tools/tld_cleanup/tld_cleanup.gyp View 1 2 3 4 1 chunk +4 lines, -3 lines 0 comments Download
A net/tools/tld_cleanup/tld_cleanup_util.h View 1 2 3 4 1 chunk +48 lines, -0 lines 0 comments Download
A + net/tools/tld_cleanup/tld_cleanup_util.cc View 1 2 3 4 7 chunks +73 lines, -139 lines 0 comments Download
A net/tools/tld_cleanup/tld_cleanup_util_unittest.cc View 1 2 3 4 1 chunk +168 lines, -0 lines 0 comments Download
M ui/base/text/text_elider.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nyquist
pam: PTAL at patch set 2 diff from patch set 1 for the file: net/tools/tld_cleanup/tld_cleanup_util.cc ...
7 years, 7 months ago (2013-05-14 05:30:23 UTC) #1
Pam (message me for reviews)
LGTM once the win_x64_rel builder passes. - Pam
7 years, 7 months ago (2013-05-14 07:44:28 UTC) #2
nyquist
7 years, 7 months ago (2013-05-14 20:49:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r200066 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698