chrome/browser/ui/web_contents_modal_dialog_manager.cc - Issue 15140003: Add support for split Public Suffix List distinctions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/web_contents_modal_dialog_manager.cc

Issue 15140003: Add support for split Public Suffix List distinctions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased again Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/web_contents_modal_dialog_manager.cc

diff --git a/chrome/browser/ui/web_contents_modal_dialog_manager.cc b/chrome/browser/ui/web_contents_modal_dialog_manager.cc

index 2b72e4a94020355dc356ff41309d286e486c4f73..582f00f7100b454432e1bd32ef3e8ee7b72d6d5e 100644

--- a/chrome/browser/ui/web_contents_modal_dialog_manager.cc

+++ b/chrome/browser/ui/web_contents_modal_dialog_manager.cc

@@ -133,8 +133,9 @@ void WebContentsModalDialogManager::DidNavigateMainFrame(

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) {

// Close constrained windows if necessary.

- if (!net::RegistryControlledDomainService::SameDomainOrHost(

- details.previous_url, details.entry->GetURL()))

+ if (!net::registry_controlled_domains::SameDomainOrHost(

+ details.previous_url, details.entry->GetURL(),

+ net::registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES))

CloseAllDialogs();

}