Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: net/tools/tld_cleanup/README

Issue 15140003: Add support for split Public Suffix List distinctions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased again Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ssl/server_bound_cert_service.cc ('k') | net/tools/tld_cleanup/tld_cleanup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/tld_cleanup/README
diff --git a/net/tools/tld_cleanup/README b/net/tools/tld_cleanup/README
index adaac7e3a30d88bff25c8d9eda7ecc1680e9bd1d..7b468b50d46fbb03f53e1c324dd4e1641cae3aec 100644
--- a/net/tools/tld_cleanup/README
+++ b/net/tools/tld_cleanup/README
@@ -4,18 +4,27 @@ When updating src/net/base/registry_controlled_domains/effective_tld_names.dat:
http://goo.gl/Ji2bB
2. Remove whitespace from the ends of the lines.
+ You could possibly use something like:
+ sed -i -e "s/\s*$//g" \
+ src/net/base/registry_controlled_domains/effective_tld_names.dat
-3. Add the Chromium note back in.
+3. Add the Chromium note back in just after the license at the top, and just
+ before '===BEGIN ICANN DOMAINS==='. Ensure there is an empty line above and
+ two empty lines below the note. The note should say:
+// Chromium note: this is based on Mozilla's file:
+// http://mxr.mozilla.org/mozilla-central/source/netwerk/dns/effective_tld_names.dat?raw=1
-4. Build tld_cleanup.exe (the "(net)" > "tld_cleanup" project)
+4. Build tld_cleanup (the "(net)" > "tld_cleanup" project)
5. Run it (no arguments needed), typically from src/build/Release or
src/build/Debug. It will re-generate
src/net/base/registry_controlled_domains/effective_tld_names.gperf.
6. Run gperf on the new effective_tld_names.gperf:
+ pushd src/net/base/registry_controlled_domains;
gperf -a -L "C++" -C -c -o -t -k '*' -NFindDomain -D -m 5 \
- effective_tld_names.gperf > effective_tld_names.cc
+ effective_tld_names.gperf > effective_tld_names.cc;
+ popd;
It will produce a new effective_tld_names.cc.
7. Check in the updated effective_tld_names.dat, effective_tld_names.gperf,
« no previous file with comments | « net/ssl/server_bound_cert_service.cc ('k') | net/tools/tld_cleanup/tld_cleanup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698