Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Side by Side Diff: net/tools/tld_cleanup/README

Issue 15140003: Add support for split Public Suffix List distinctions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased again Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/ssl/server_bound_cert_service.cc ('k') | net/tools/tld_cleanup/tld_cleanup.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 When updating src/net/base/registry_controlled_domains/effective_tld_names.dat: 1 When updating src/net/base/registry_controlled_domains/effective_tld_names.dat:
2 2
3 1. Obtain the new effective_tld_names.dat, probably by downloading 3 1. Obtain the new effective_tld_names.dat, probably by downloading
4 http://goo.gl/Ji2bB 4 http://goo.gl/Ji2bB
5 5
6 2. Remove whitespace from the ends of the lines. 6 2. Remove whitespace from the ends of the lines.
7 You could possibly use something like:
8 sed -i -e "s/\s*$//g" \
9 src/net/base/registry_controlled_domains/effective_tld_names.dat
7 10
8 3. Add the Chromium note back in. 11 3. Add the Chromium note back in just after the license at the top, and just
12 before '===BEGIN ICANN DOMAINS==='. Ensure there is an empty line above and
13 two empty lines below the note. The note should say:
14 // Chromium note: this is based on Mozilla's file:
15 // http://mxr.mozilla.org/mozilla-central/source/netwerk/dns/effective_tld_name s.dat?raw=1
9 16
10 4. Build tld_cleanup.exe (the "(net)" > "tld_cleanup" project) 17 4. Build tld_cleanup (the "(net)" > "tld_cleanup" project)
11 18
12 5. Run it (no arguments needed), typically from src/build/Release or 19 5. Run it (no arguments needed), typically from src/build/Release or
13 src/build/Debug. It will re-generate 20 src/build/Debug. It will re-generate
14 src/net/base/registry_controlled_domains/effective_tld_names.gperf. 21 src/net/base/registry_controlled_domains/effective_tld_names.gperf.
15 22
16 6. Run gperf on the new effective_tld_names.gperf: 23 6. Run gperf on the new effective_tld_names.gperf:
24 pushd src/net/base/registry_controlled_domains;
17 gperf -a -L "C++" -C -c -o -t -k '*' -NFindDomain -D -m 5 \ 25 gperf -a -L "C++" -C -c -o -t -k '*' -NFindDomain -D -m 5 \
18 effective_tld_names.gperf > effective_tld_names.cc 26 effective_tld_names.gperf > effective_tld_names.cc;
27 popd;
19 It will produce a new effective_tld_names.cc. 28 It will produce a new effective_tld_names.cc.
20 29
21 7. Check in the updated effective_tld_names.dat, effective_tld_names.gperf, 30 7. Check in the updated effective_tld_names.dat, effective_tld_names.gperf,
22 and effective_tld_names.cc together. 31 and effective_tld_names.cc together.
OLDNEW
« no previous file with comments | « net/ssl/server_bound_cert_service.cc ('k') | net/tools/tld_cleanup/tld_cleanup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698