Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1507603004: Merge fix for 552999 to m48(Always use high precision on NDS transform) (Closed)

Created:
5 years ago by Joel.Liang
Modified:
5 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m48
Target Ref:
refs/heads/chrome/m48
Project:
skia
Visibility:
Public.

Description

Merge fix for 552999 to m48(Always use high precision on NDS transform) Original CL: https://codereview.chromium.org/1500393002 To fix the Chrome fillRect issue on Galaxy S6. We should use high precision for position related calculation. BUG=chromium:552999 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/5bcbe5e887740b51a488f25db05f74f66dd25ecd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLVertexShaderBuilder.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507603004/1
5 years ago (2015-12-08 08:36:53 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years ago (2015-12-08 08:36:53 UTC) #6
Joel.Liang
Hi Brian, I have merged fix for 552999 to m48(Always use high precision on NDS ...
5 years ago (2015-12-08 08:40:14 UTC) #7
bsalomon
lgtm
5 years ago (2015-12-08 13:54:10 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-08 13:54:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1507603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1507603004/1
5 years ago (2015-12-09 03:30:01 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-09 03:30:12 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5bcbe5e887740b51a488f25db05f74f66dd25ecd

Powered by Google App Engine
This is Rietveld 408576698