Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1501153002: Revert of clang/win: Enable -Wunused-value completely. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
hans, Will Harris
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of clang/win: Enable -Wunused-value completely. (patchset #3 id:40001 of https://codereview.chromium.org/1500783002/ ) Reason for revert: This works in debug builds but not in release builds yet. Original issue's description: > clang/win: Enable -Wunused-value completely. > > BUG=505318 > NOTRY=true > > Committed: https://crrev.com/b10a7ada601a07866d50cd13c6af4605e316152e > Cr-Commit-Position: refs/heads/master@{#363327} TBR=hans@chromium.org,wfh@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=505318 Committed: https://crrev.com/9f1715d0cd8bb5c2bcfd00c55aff80e3fb0b7caf Cr-Commit-Position: refs/heads/master@{#363331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/sid.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
Created Revert of clang/win: Enable -Wunused-value completely.
5 years ago (2015-12-05 02:35:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501153002/1
5 years ago (2015-12-05 02:38:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-05 02:42:58 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9f1715d0cd8bb5c2bcfd00c55aff80e3fb0b7caf Cr-Commit-Position: refs/heads/master@{#363331}
5 years ago (2015-12-05 02:43:58 UTC) #5
Nico
5 years ago (2015-12-07 22:47:56 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1507113002/ by thakis@chromium.org.

The reason for reverting is: This might now work in release builds too..

Powered by Google App Engine
This is Rietveld 408576698