build/config/compiler/BUILD.gn - Issue 1501153002: Revert of clang/win: Enable -Wunused-value completely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1501153002: Revert of clang/win: Enable -Wunused-value completely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index c9837f31b33f0cde76ea4b6e0324d65199d11eea..08d10a494fa019f7002074a59b999a1a7405d730 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -771,6 +771,10 @@

"-Wno-microsoft-enum-value", # http://crbug.com/505296

"-Wno-unknown-pragmas", # http://crbug.com/505314

"-Wno-microsoft-cast", # http://crbug.com/550065

+ # Disable unused-value (crbug.com/505318) except -Wunused-result.

+ "-Wno-unused-value",

+ "-Wunused-result",

]

}

} else {

« no previous file with comments | « build/common.gypi ('k') | chrome/installer/setup/setup_util_unittest.cc » ('j') | no next file with comments »