Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: build/common.gypi

Issue 1501153002: Revert of clang/win: Enable -Wunused-value completely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5794 matching lines...) Expand 10 before | Expand all | Expand 10 after
5805 'AdditionalOptions': [ 5805 'AdditionalOptions': [
5806 # Many files use intrinsics without including this header. 5806 # Many files use intrinsics without including this header.
5807 # TODO(hans): Fix those files, or move this to sub-GYPs. 5807 # TODO(hans): Fix those files, or move this to sub-GYPs.
5808 '/FIIntrin.h', 5808 '/FIIntrin.h',
5809 5809
5810 # TODO(hans): Make this list shorter eventually, http://crbug. com/504657 5810 # TODO(hans): Make this list shorter eventually, http://crbug. com/504657
5811 '-Qunused-arguments', # http://crbug.com/504658 5811 '-Qunused-arguments', # http://crbug.com/504658
5812 '-Wno-microsoft-enum-value', # http://crbug.com/505296 5812 '-Wno-microsoft-enum-value', # http://crbug.com/505296
5813 '-Wno-unknown-pragmas', # http://crbug.com/505314 5813 '-Wno-unknown-pragmas', # http://crbug.com/505314
5814 '-Wno-microsoft-cast', # http://crbug.com/550065 5814 '-Wno-microsoft-cast', # http://crbug.com/550065
5815 # Disable unused-value (crbug.com/505318) except
5816 # -Wunused-result.
5817 '-Wno-unused-value',
5818 '-Wunused-result',
5815 ], 5819 ],
5816 }, 5820 },
5817 }], 5821 }],
5818 ['clang==1 and clang_use_chrome_plugins==1', { 5822 ['clang==1 and clang_use_chrome_plugins==1', {
5819 'VCCLCompilerTool': { 5823 'VCCLCompilerTool': {
5820 'AdditionalOptions': [ 5824 'AdditionalOptions': [
5821 '<@(clang_chrome_plugins_flags)', 5825 '<@(clang_chrome_plugins_flags)',
5822 ], 5826 ],
5823 }, 5827 },
5824 }], 5828 }],
(...skipping 541 matching lines...) Expand 10 before | Expand all | Expand 10 after
6366 # settings in target dicts. SYMROOT is a special case, because many other 6370 # settings in target dicts. SYMROOT is a special case, because many other
6367 # Xcode variables depend on it, including variables such as 6371 # Xcode variables depend on it, including variables such as
6368 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6372 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6369 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6373 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6370 # files to appear (when present) in the UI as actual files and not red 6374 # files to appear (when present) in the UI as actual files and not red
6371 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6375 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6372 # and therefore SYMROOT, needs to be set at the project level. 6376 # and therefore SYMROOT, needs to be set at the project level.
6373 'SYMROOT': '<(DEPTH)/xcodebuild', 6377 'SYMROOT': '<(DEPTH)/xcodebuild',
6374 }, 6378 },
6375 } 6379 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698