chrome/installer/setup/setup_util_unittest.cc - Issue 1501153002: Revert of clang/win: Enable -Wunused-value completely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/setup_util_unittest.cc

Issue 1501153002: Revert of clang/win: Enable -Wunused-value completely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/setup_util_unittest.cc

diff --git a/chrome/installer/setup/setup_util_unittest.cc b/chrome/installer/setup/setup_util_unittest.cc

index d8a5c850307c981691dab450bd5d12e15c82b2cf..61077794cc1e689c76a1fe824cb81d2b4ca60e68 100644

--- a/chrome/installer/setup/setup_util_unittest.cc

+++ b/chrome/installer/setup/setup_util_unittest.cc

@@ -617,7 +617,7 @@

{

base::win::RegistryKeyIterator it(root_, path_.c_str());

ASSERT_EQ(to_preserve_.size(), it.SubkeyCount());

- for (; it.Valid(); ++it) {

+ for (it; it.Valid(); ++it) {

ASSERT_NE(to_preserve_.end(),

std::find_if(to_preserve_.begin(), to_preserve_.end(),

[&it](const base::string16& key_name) {

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | sandbox/win/src/sid.cc » ('j') | no next file with comments »