Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1501153002: Revert of clang/win: Enable -Wunused-value completely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/installer/setup/setup_util_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/ccache.gni") 9 import("//build/toolchain/ccache.gni")
10 10
(...skipping 753 matching lines...) Expand 10 before | Expand all | Expand 10 after
764 # Building with Clang on Windows is a work in progress and very 764 # Building with Clang on Windows is a work in progress and very
765 # experimental. See crbug.com/82385. 765 # experimental. See crbug.com/82385.
766 # Keep this in sync with the similar block in build/common.gypi 766 # Keep this in sync with the similar block in build/common.gypi
767 if (is_clang) { 767 if (is_clang) {
768 cflags += [ 768 cflags += [
769 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657 769 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657
770 "-Qunused-arguments", # http://crbug.com/504658 770 "-Qunused-arguments", # http://crbug.com/504658
771 "-Wno-microsoft-enum-value", # http://crbug.com/505296 771 "-Wno-microsoft-enum-value", # http://crbug.com/505296
772 "-Wno-unknown-pragmas", # http://crbug.com/505314 772 "-Wno-unknown-pragmas", # http://crbug.com/505314
773 "-Wno-microsoft-cast", # http://crbug.com/550065 773 "-Wno-microsoft-cast", # http://crbug.com/550065
774
775 # Disable unused-value (crbug.com/505318) except -Wunused-result.
776 "-Wno-unused-value",
777 "-Wunused-result",
774 ] 778 ]
775 } 779 }
776 } else { 780 } else {
777 # Common GCC warning setup. 781 # Common GCC warning setup.
778 cflags += [ 782 cflags += [
779 # Enables. 783 # Enables.
780 "-Wendif-labels", # Weird old-style text after an #endif. 784 "-Wendif-labels", # Weird old-style text after an #endif.
781 785
782 # Disables. 786 # Disables.
783 "-Wno-missing-field-initializers", # "struct foo f = {0};" 787 "-Wno-missing-field-initializers", # "struct foo f = {0};"
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
1304 if (symbol_level == 0) { 1308 if (symbol_level == 0) {
1305 configs = [ ":no_symbols" ] 1309 configs = [ ":no_symbols" ]
1306 } else if (symbol_level == 1) { 1310 } else if (symbol_level == 1) {
1307 configs = [ ":minimal_symbols" ] 1311 configs = [ ":minimal_symbols" ]
1308 } else if (symbol_level == 2) { 1312 } else if (symbol_level == 2) {
1309 configs = [ ":symbols" ] 1313 configs = [ ":symbols" ]
1310 } else { 1314 } else {
1311 assert(false) 1315 assert(false)
1312 } 1316 }
1313 } 1317 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | chrome/installer/setup/setup_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698