Make platform/graphics to use USING_FAST_MALLOC.

Make platform/graphics to use USING_FAST_MALLOC.

BUG=562431
Committed: https://crrev.com/d3aa9b15149a53d2b4f72c0a9c6d7e71fdd615de
Cr-Commit-Position: refs/heads/master@{#362950}

[tasak, 2015-12-03 09:01:57]

tasak@google.com changed reviewers:
+ haraken@chromium.org

[tasak, 2015-12-03 09:01:57]

PTAL?

[haraken, 2015-12-03 10:30:08]

LGTM

[tasak, 2015-12-03 10:49:30]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2015-12-03 10:49:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1497683002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1497683002/40001

[commit-bot: I haz the power, 2015-12-03 10:57:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-03 10:58:00]

Description was changed from

==========
Make platform/graphics to use USING_FAST_MALLOC.

BUG=562431
==========

to

==========
Make platform/graphics to use USING_FAST_MALLOC.

BUG=562431

Committed: https://crrev.com/d3aa9b15149a53d2b4f72c0a9c6d7e71fdd615de
Cr-Commit-Position: refs/heads/master@{#362950}
==========

[commit-bot: I haz the power, 2015-12-03 10:58:01]

Patchset 3 (id:??) landed as
https://crrev.com/d3aa9b15149a53d2b4f72c0a9c6d7e71fdd615de
Cr-Commit-Position: refs/heads/master@{#362950}

[aleksandar.stojiljkovic, 2015-12-03 23:29:41]

aleksandar.stojiljkovic@intel.com changed reviewers:
+ aleksandar.stojiljkovic@intel.com

[aleksandar.stojiljkovic, 2015-12-03 23:29:42]

https://codereview.chromium.org/1497683002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.h
(right):

https://codereview.chromium.org/1497683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.h:49:
DISALLOW_NEW();
tasak@, while rebasing this, hit the merge issue with this.
Usage of this class changed, it is now like:
class PLATFORM_EXPORT ThreadSafeDataTransport final : public
ThreadSafeRefCounted<ThreadSafeDataTransport> {
    WTF_MAKE_NONCOPYABLE(ThreadSafeDataTransport);

https://codereview.chromium.org/1484853003/

Could you please comment if you're fine with removing DISALLOW_NEW from
ThreadSafeDataTransport?
Thanks.

[haraken, 2015-12-03 23:33:17]

On 2015/12/03 23:29:42, aleksandar.stojiljkovic wrote:
>
https://codereview.chromium.org/1497683002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.h
> (right):
> 
>
https://codereview.chromium.org/1497683002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.h:49:
> DISALLOW_NEW();
> tasak@, while rebasing this, hit the merge issue with this.
> Usage of this class changed, it is now like:
> class PLATFORM_EXPORT ThreadSafeDataTransport final : public
> ThreadSafeRefCounted<ThreadSafeDataTransport> {
>     WTF_MAKE_NONCOPYABLE(ThreadSafeDataTransport);
> 
> https://codereview.chromium.org/1484853003/
> 
> Could you please comment if you're fine with removing DISALLOW_NEW from
> ThreadSafeDataTransport?
> Thanks.

You can remove DISALLOW_NEW and add USING_FAST_MALLOC.

[aleksandar.stojiljkovic, 2015-12-04 12:13:46]

On 2015/12/03 23:33:17, haraken wrote:
> On 2015/12/03 23:29:42, aleksandar.stojiljkovic wrote:
> >
>
https://codereview.chromium.org/1497683002/diff/40001/third_party/WebKit/Sour...
> > File third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.h
> > (right):
> > 
> >
>
https://codereview.chromium.org/1497683002/diff/40001/third_party/WebKit/Sour...
> > third_party/WebKit/Source/platform/graphics/ThreadSafeDataTransport.h:49:
> > DISALLOW_NEW();
> > tasak@, while rebasing this, hit the merge issue with this.
> > Usage of this class changed, it is now like:
> > class PLATFORM_EXPORT ThreadSafeDataTransport final : public
> > ThreadSafeRefCounted<ThreadSafeDataTransport> {
> >     WTF_MAKE_NONCOPYABLE(ThreadSafeDataTransport);
> > 
> > https://codereview.chromium.org/1484853003/
> > 
> > Could you please comment if you're fine with removing DISALLOW_NEW from
> > ThreadSafeDataTransport?
> > Thanks.
> 
> You can remove DISALLOW_NEW and add USING_FAST_MALLOC.

@haraken, good morning.

Sorry if misusing this review for another issue - looks related:

This combination is causing memory leak (more info in the bot log):
class PLATFORM_EXPORT ThreadSafeDataTransport final : public
ThreadSafeRefCounted<ThreadSafeDataTransport> {
    WTF_MAKE_NONCOPYABLE(ThreadSafeDataTransport);
    USING_FAST_MALLOC(ThreadSafeDataTransport);

http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...

After I removed USING_FAST_MALLOC(ThreadSafeDataTransport), asan build seems
fine:

http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...

Also, noticed that USING_FAST_MALLOC is not on other places combined with
RefCounted or ThreadSafeRefCounted (a lot of those - maybe there are I just
wasn't able to see/grep them).