Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Issue 1496493002: Pass explicit Isolate parameter to v8::Debug methods that need it (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pass explicit Isolate parameter to v8::Debug methods that need it BUG=v8:2487 LOG=n R=vogelheim@chromium.org Committed: https://crrev.com/6c0d1a11006168d5852302f3a7fb38943c7e2c7e Cr-Commit-Position: refs/heads/master@{#32509}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -336 lines) Patch
M include/v8-debug.h View 4 chunks +14 lines, -4 lines 0 comments Download
M src/api.cc View 3 chunks +37 lines, -15 lines 1 comment Download
M test/cctest/cctest.h View 1 chunk +5 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-debug.cc View 200 chunks +343 lines, -308 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-12-02 11:13:20 UTC) #1
vogelheim
lgtm https://codereview.chromium.org/1496493002/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1496493002/diff/1/src/api.cc#newcode7746 src/api.cc:7746: reinterpret_cast<Isolate*>(i::Isolate::Current()), that, data); Meh... reinterpret_cast-ing i::Isolate to Isolate ...
5 years ago (2015-12-02 11:38:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496493002/1
5 years ago (2015-12-02 12:04:26 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 12:47:20 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-02 12:47:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c0d1a11006168d5852302f3a7fb38943c7e2c7e
Cr-Commit-Position: refs/heads/master@{#32509}

Powered by Google App Engine
This is Rietveld 408576698