Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: test/cctest/cctest.h

Issue 1496493002: Pass explicit Isolate parameter to v8::Debug methods that need it (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 661 matching lines...) Expand 10 before | Expand all | Expand 10 after
672 } 672 }
673 } 673 }
674 CHECK(marking->IsComplete()); 674 CHECK(marking->IsComplete());
675 } 675 }
676 676
677 677
678 static void DummyDebugEventListener( 678 static void DummyDebugEventListener(
679 const v8::Debug::EventDetails& event_details) {} 679 const v8::Debug::EventDetails& event_details) {}
680 680
681 681
682 static inline void EnableDebugger() { 682 static inline void EnableDebugger(v8::Isolate* isolate) {
683 v8::Debug::SetDebugEventListener(&DummyDebugEventListener); 683 v8::Debug::SetDebugEventListener(isolate, &DummyDebugEventListener);
684 } 684 }
685 685
686 686
687 static inline void DisableDebugger() { v8::Debug::SetDebugEventListener(NULL); } 687 static inline void DisableDebugger(v8::Isolate* isolate) {
688 v8::Debug::SetDebugEventListener(isolate, nullptr);
689 }
688 690
689 691
690 static inline void EmptyMessageQueues(v8::Isolate* isolate) { 692 static inline void EmptyMessageQueues(v8::Isolate* isolate) {
691 while (v8::platform::PumpMessageLoop(v8::internal::V8::GetCurrentPlatform(), 693 while (v8::platform::PumpMessageLoop(v8::internal::V8::GetCurrentPlatform(),
692 isolate)) { 694 isolate)) {
693 } 695 }
694 } 696 }
695 697
696 698
697 class InitializedHandleScope { 699 class InitializedHandleScope {
(...skipping 16 matching lines...) Expand all
714 HandleAndZoneScope() {} 716 HandleAndZoneScope() {}
715 717
716 // Prefixing the below with main_ reduces a lot of naming clashes. 718 // Prefixing the below with main_ reduces a lot of naming clashes.
717 i::Zone* main_zone() { return &main_zone_; } 719 i::Zone* main_zone() { return &main_zone_; }
718 720
719 private: 721 private:
720 i::Zone main_zone_; 722 i::Zone main_zone_;
721 }; 723 };
722 724
723 #endif // ifndef CCTEST_H_ 725 #endif // ifndef CCTEST_H_
OLDNEW
« src/api.cc ('K') | « src/api.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698