Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: include/v8-debug.h

Issue 1496493002: Pass explicit Isolate parameter to v8::Debug methods that need it (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-debug.h
diff --git a/include/v8-debug.h b/include/v8-debug.h
index 0b64fb38829eb8d0e99ef8b6181df86e94fd940d..e802a5235d6a61c8ba7f01ebc13348b9f3ad9bf7 100644
--- a/include/v8-debug.h
+++ b/include/v8-debug.h
@@ -155,8 +155,12 @@ class V8_EXPORT Debug {
*/
typedef void (*DebugMessageDispatchHandler)();
- static bool SetDebugEventListener(EventCallback that,
+ static bool SetDebugEventListener(Isolate* isolate, EventCallback that,
Local<Value> data = Local<Value>());
+ V8_DEPRECATE_SOON(
+ "Use version with an Isolate",
+ static bool SetDebugEventListener(EventCallback that,
+ Local<Value> data = Local<Value>()));
// Schedule a debugger break to happen when JavaScript code is run
// in the given isolate.
@@ -170,7 +174,9 @@ class V8_EXPORT Debug {
static bool CheckDebugBreak(Isolate* isolate);
// Message based interface. The message protocol is JSON.
- static void SetMessageHandler(MessageHandler handler);
+ static void SetMessageHandler(Isolate* isolate, MessageHandler handler);
+ V8_DEPRECATE_SOON("Use version with an Isolate",
+ static void SetMessageHandler(MessageHandler handler));
static void SendCommand(Isolate* isolate,
const uint16_t* command, int length,
@@ -242,7 +248,9 @@ class V8_EXPORT Debug {
* "Evaluate" debug command behavior currently is not specified in scope
* of this method.
*/
- static void ProcessDebugMessages();
+ static void ProcessDebugMessages(Isolate* isolate);
+ V8_DEPRECATE_SOON("Use version with an Isolate",
+ static void ProcessDebugMessages());
/**
* Debugger is running in its own context which is entered while debugger
@@ -251,7 +259,9 @@ class V8_EXPORT Debug {
* to change. The Context exists only when the debugger is active, i.e. at
* least one DebugEventListener or MessageHandler is set.
*/
- static Local<Context> GetDebugContext();
+ static Local<Context> GetDebugContext(Isolate* isolate);
+ V8_DEPRECATE_SOON("Use version with an Isolate",
+ static Local<Context> GetDebugContext());
/**
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/api.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698