Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: test/cctest/cctest.h

Issue 1496493002: Pass explicit Isolate parameter to v8::Debug methods that need it (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/api.cc ('K') | « src/api.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/cctest.h
diff --git a/test/cctest/cctest.h b/test/cctest/cctest.h
index c20e573e57714837f371fa9c81f38261d1c6f65f..6806ca6e665f4906f1af6b9cc2c30ca708201939 100644
--- a/test/cctest/cctest.h
+++ b/test/cctest/cctest.h
@@ -679,12 +679,14 @@ static void DummyDebugEventListener(
const v8::Debug::EventDetails& event_details) {}
-static inline void EnableDebugger() {
- v8::Debug::SetDebugEventListener(&DummyDebugEventListener);
+static inline void EnableDebugger(v8::Isolate* isolate) {
+ v8::Debug::SetDebugEventListener(isolate, &DummyDebugEventListener);
}
-static inline void DisableDebugger() { v8::Debug::SetDebugEventListener(NULL); }
+static inline void DisableDebugger(v8::Isolate* isolate) {
+ v8::Debug::SetDebugEventListener(isolate, nullptr);
+}
static inline void EmptyMessageQueues(v8::Isolate* isolate) {
« src/api.cc ('K') | « src/api.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698