Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: test/cctest/test-api.cc

Issue 1496493002: Pass explicit Isolate parameter to v8::Debug methods that need it (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index c1cd5d1fde95a109677a858f789cc3c846460c31..ed8adfd4c0343384727c0f53a1eb1fe95bbb7599 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -20146,7 +20146,7 @@ TEST(Regress385349) {
HandleScope handle_scope(isolate);
isolate->SetAutorunMicrotasks(false);
Local<Context> context = Context::New(isolate);
- v8::Debug::SetDebugEventListener(DebugEventInObserver);
+ v8::Debug::SetDebugEventListener(isolate, DebugEventInObserver);
{
Context::Scope context_scope(context);
CompileRun("var obj = {};"
@@ -20155,7 +20155,7 @@ TEST(Regress385349) {
}
isolate->RunMicrotasks();
isolate->SetAutorunMicrotasks(true);
- v8::Debug::SetDebugEventListener(NULL);
+ v8::Debug::SetDebugEventListener(isolate, nullptr);
}
@@ -22691,7 +22691,7 @@ TEST(StreamingWithDebuggingEnabledLate) {
v8::ScriptOrigin origin(v8_str("http://foo.com"));
char* full_source = TestSourceStream::FullSourceString(chunks);
- EnableDebugger();
+ EnableDebugger(isolate);
v8::Local<Script> script = v8::ScriptCompiler::Compile(
isolate, &source, v8_str(full_source), origin);
@@ -22702,7 +22702,7 @@ TEST(StreamingWithDebuggingEnabledLate) {
delete[] full_source;
- DisableDebugger();
+ DisableDebugger(isolate);
}
« src/api.cc ('K') | « test/cctest/cctest.h ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698