Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1496103002: Reusing base::IdType<...> to implement SurfaceId.

Created:
5 years ago by Łukasz Anforowicz
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews, rjkroege, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@type-safe-id-base
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reusing base::IdType<...> to implement SurfaceId. BUG=565545 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Patch Set 2 : Rebasing + dusting off... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -165 lines) Patch
M cc/layers/surface_layer_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/surface_layer_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/surface_layer_unittest.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download
M cc/quads/draw_quad_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/surface_draw_quad.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/quads/surface_draw_quad.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M cc/surfaces/display_scheduler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/display_scheduler_unittest.cc View 1 8 chunks +19 lines, -19 lines 0 comments Download
M cc/surfaces/display_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M cc/surfaces/surface_aggregator.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M cc/surfaces/surface_aggregator_perftest.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 1 7 chunks +10 lines, -11 lines 0 comments Download
M cc/surfaces/surface_factory.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_factory_client.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/surfaces/surface_factory_unittest.cc View 1 6 chunks +7 lines, -6 lines 0 comments Download
M cc/surfaces/surface_hittest_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/surfaces/surface_id.h View 1 1 chunk +3 lines, -30 lines 0 comments Download
M cc/surfaces/surface_id_allocator.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M cc/surfaces/surface_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/test/surface_aggregator_test_helpers.h View 1 2 chunks +4 lines, -22 lines 0 comments Download
M cc/test/surface_aggregator_test_helpers.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M components/html_viewer/html_frame.cc View 1 2 chunks +8 lines, -6 lines 0 comments Download
M components/mus/surfaces/top_level_display_client.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/ws/display_manager_delegate.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M components/mus/ws/server_window_surface.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_finder.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/frame_host/cross_process_frame_connector.h View 1 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_input_event_router.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/cc_messages.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/cc_messages_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 1 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_frame_proxy.h View 1 2 chunks +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/converters/surfaces/tests/surface_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1548443002 Patch 40001

Messages

Total messages: 1 (1 generated)
Łukasz Anforowicz
5 years ago (2015-12-03 20:49:56 UTC) #1 
Description was changed from

==========
Reusing base::IdType<...> to implement SurfaceId.

BUG=565545
==========

to

==========
Reusing base::IdType<...> to implement SurfaceId.

BUG=565545
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

Powered by Google App Engine
This is Rietveld 408576698