cc/quads/draw_quad_unittest.cc - Issue 1496103002: Reusing base::IdType<...> to implement SurfaceId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/quads/draw_quad_unittest.cc

Issue 1496103002: Reusing base::IdType<...> to implement SurfaceId. Base URL: https://chromium.googlesource.com/chromium/src.git@type-safe-id-base

Patch Set: Rebasing + dusting off... Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/quads/draw_quad_unittest.cc

diff --git a/cc/quads/draw_quad_unittest.cc b/cc/quads/draw_quad_unittest.cc

index cfc20a17901deff1fd7430bc25c81bdaced5c03d..8beb502262a18436f7c208036cdfb146bd1ee690 100644

--- a/cc/quads/draw_quad_unittest.cc

+++ b/cc/quads/draw_quad_unittest.cc

@@ -507,7 +507,7 @@ TEST(DrawQuadTest, CopyStreamVideoDrawQuad) {

TEST(DrawQuadTest, CopySurfaceDrawQuad) {

gfx::Rect visible_rect(40, 50, 30, 20);

- SurfaceId surface_id(1234);

+ SurfaceId surface_id = SurfaceId::FromUnsafeValue(1234);

CREATE_SHARED_STATE();

CREATE_QUAD_2_NEW(SurfaceDrawQuad, visible_rect, surface_id);

@@ -807,7 +807,7 @@ TEST_F(DrawQuadIteratorTest, StreamVideoDrawQuad) {

TEST_F(DrawQuadIteratorTest, SurfaceDrawQuad) {

gfx::Rect visible_rect(40, 50, 30, 20);

- SurfaceId surface_id(4321);

+ SurfaceId surface_id = SurfaceId::FromUnsafeValue(4321);

CREATE_SHARED_STATE();

CREATE_QUAD_2_NEW(SurfaceDrawQuad, visible_rect, surface_id);

« no previous file with comments | « cc/layers/surface_layer_unittest.cc ('k') | cc/quads/surface_draw_quad.h » ('j') | no next file with comments »