Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Side by Side Diff: cc/layers/surface_layer_unittest.cc

Issue 1496103002: Reusing base::IdType<...> to implement SurfaceId. Base URL: https://chromium.googlesource.com/chromium/src.git@type-safe-id-base
Patch Set: Rebasing + dusting off... Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/layers/surface_layer_impl_unittest.cc ('k') | cc/quads/draw_quad_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 // Check that one surface can be referenced by multiple LayerTreeHosts, and 67 // Check that one surface can be referenced by multiple LayerTreeHosts, and
68 // each will create its own SurfaceSequence that's satisfied on destruction. 68 // each will create its own SurfaceSequence that's satisfied on destruction.
69 TEST_F(SurfaceLayerTest, MultipleFramesOneSurface) { 69 TEST_F(SurfaceLayerTest, MultipleFramesOneSurface) {
70 SurfaceSequence blank_change; // Receives sequence if commit doesn't happen. 70 SurfaceSequence blank_change; // Receives sequence if commit doesn't happen.
71 71
72 SurfaceId required_id; 72 SurfaceId required_id;
73 std::set<SurfaceSequence> required_seq; 73 std::set<SurfaceSequence> required_seq;
74 scoped_refptr<SurfaceLayer> layer(SurfaceLayer::Create( 74 scoped_refptr<SurfaceLayer> layer(SurfaceLayer::Create(
75 layer_settings_, base::Bind(&SatisfyCallback, &blank_change), 75 layer_settings_, base::Bind(&SatisfyCallback, &blank_change),
76 base::Bind(&RequireCallback, &required_id, &required_seq))); 76 base::Bind(&RequireCallback, &required_id, &required_seq)));
77 layer->SetSurfaceId(SurfaceId(1), 1.f, gfx::Size(1, 1)); 77 layer->SetSurfaceId(SurfaceId::FromUnsafeValue(1), 1.f, gfx::Size(1, 1));
78 layer_tree_host_->set_surface_id_namespace(1); 78 layer_tree_host_->set_surface_id_namespace(1);
79 layer_tree_host_->SetRootLayer(layer); 79 layer_tree_host_->SetRootLayer(layer);
80 80
81 scoped_ptr<FakeLayerTreeHost> layer_tree_host2 = 81 scoped_ptr<FakeLayerTreeHost> layer_tree_host2 =
82 FakeLayerTreeHost::Create(&fake_client_, &task_graph_runner_); 82 FakeLayerTreeHost::Create(&fake_client_, &task_graph_runner_);
83 scoped_refptr<SurfaceLayer> layer2(SurfaceLayer::Create( 83 scoped_refptr<SurfaceLayer> layer2(SurfaceLayer::Create(
84 layer_settings_, base::Bind(&SatisfyCallback, &blank_change), 84 layer_settings_, base::Bind(&SatisfyCallback, &blank_change),
85 base::Bind(&RequireCallback, &required_id, &required_seq))); 85 base::Bind(&RequireCallback, &required_id, &required_seq)));
86 layer2->SetSurfaceId(SurfaceId(1), 1.f, gfx::Size(1, 1)); 86 layer2->SetSurfaceId(SurfaceId::FromUnsafeValue(1), 1.f, gfx::Size(1, 1));
87 layer_tree_host2->set_surface_id_namespace(2); 87 layer_tree_host2->set_surface_id_namespace(2);
88 layer_tree_host2->SetRootLayer(layer2); 88 layer_tree_host2->SetRootLayer(layer2);
89 89
90 // Layers haven't been removed, so no sequence should be satisfied. 90 // Layers haven't been removed, so no sequence should be satisfied.
91 EXPECT_TRUE(blank_change.is_null()); 91 EXPECT_TRUE(blank_change.is_null());
92 92
93 SurfaceSequence expected1(1u, 1u); 93 SurfaceSequence expected1(1u, 1u);
94 SurfaceSequence expected2(2u, 1u); 94 SurfaceSequence expected2(2u, 1u);
95 95
96 layer_tree_host2->SetRootLayer(nullptr); 96 layer_tree_host2->SetRootLayer(nullptr);
97 layer_tree_host2.reset(); 97 layer_tree_host2.reset();
98 98
99 // Layer was removed so sequence from second LayerTreeHost should be 99 // Layer was removed so sequence from second LayerTreeHost should be
100 // satisfied. 100 // satisfied.
101 EXPECT_TRUE(blank_change == expected2); 101 EXPECT_TRUE(blank_change == expected2);
102 102
103 // Set of sequences that need to be satisfied should include sequences from 103 // Set of sequences that need to be satisfied should include sequences from
104 // both trees. 104 // both trees.
105 EXPECT_TRUE(required_id == SurfaceId(1)); 105 EXPECT_TRUE(required_id == SurfaceId::FromUnsafeValue(1));
106 EXPECT_EQ(2u, required_seq.size()); 106 EXPECT_EQ(2u, required_seq.size());
107 EXPECT_TRUE(required_seq.count(expected1)); 107 EXPECT_TRUE(required_seq.count(expected1));
108 EXPECT_TRUE(required_seq.count(expected2)); 108 EXPECT_TRUE(required_seq.count(expected2));
109 109
110 layer_tree_host_->SetRootLayer(nullptr); 110 layer_tree_host_->SetRootLayer(nullptr);
111 layer_tree_host_.reset(); 111 layer_tree_host_.reset();
112 112
113 // Layer was removed so sequence from first LayerTreeHost should be 113 // Layer was removed so sequence from first LayerTreeHost should be
114 // satisfied. 114 // satisfied.
115 EXPECT_TRUE(blank_change == expected1); 115 EXPECT_TRUE(blank_change == expected1);
116 116
117 // No more SurfaceSequences should have been generated that need to have be 117 // No more SurfaceSequences should have been generated that need to have be
118 // satisfied. 118 // satisfied.
119 EXPECT_EQ(2u, required_seq.size()); 119 EXPECT_EQ(2u, required_seq.size());
120 } 120 }
121 121
122 // Check that SurfaceSequence is sent through swap promise. 122 // Check that SurfaceSequence is sent through swap promise.
123 class SurfaceLayerSwapPromise : public LayerTreeTest { 123 class SurfaceLayerSwapPromise : public LayerTreeTest {
124 public: 124 public:
125 SurfaceLayerSwapPromise() 125 SurfaceLayerSwapPromise()
126 : commit_count_(0), sequence_was_satisfied_(false) {} 126 : commit_count_(0), sequence_was_satisfied_(false) {}
127 127
128 void BeginTest() override { 128 void BeginTest() override {
129 layer_tree_host()->set_surface_id_namespace(1); 129 layer_tree_host()->set_surface_id_namespace(1);
130 layer_ = SurfaceLayer::Create( 130 layer_ = SurfaceLayer::Create(
131 layer_settings(), base::Bind(&SatisfyCallback, &satisfied_sequence_), 131 layer_settings(), base::Bind(&SatisfyCallback, &satisfied_sequence_),
132 base::Bind(&RequireCallback, &required_id_, &required_set_)); 132 base::Bind(&RequireCallback, &required_id_, &required_set_));
133 layer_->SetSurfaceId(SurfaceId(1), 1.f, gfx::Size(1, 1)); 133 layer_->SetSurfaceId(SurfaceId::FromUnsafeValue(1), 1.f, gfx::Size(1, 1));
134 134
135 // Layer hasn't been added to tree so no SurfaceSequence generated yet. 135 // Layer hasn't been added to tree so no SurfaceSequence generated yet.
136 EXPECT_EQ(0u, required_set_.size()); 136 EXPECT_EQ(0u, required_set_.size());
137 137
138 layer_tree_host()->SetRootLayer(layer_); 138 layer_tree_host()->SetRootLayer(layer_);
139 139
140 // Should have SurfaceSequence from first tree. 140 // Should have SurfaceSequence from first tree.
141 SurfaceSequence expected(1u, 1u); 141 SurfaceSequence expected(1u, 1u);
142 EXPECT_TRUE(required_id_ == SurfaceId(1)); 142 EXPECT_TRUE(required_id_ == SurfaceId::FromUnsafeValue(1));
143 EXPECT_EQ(1u, required_set_.size()); 143 EXPECT_EQ(1u, required_set_.size());
144 EXPECT_TRUE(required_set_.count(expected)); 144 EXPECT_TRUE(required_set_.count(expected));
145 145
146 gfx::Size bounds(100, 100); 146 gfx::Size bounds(100, 100);
147 layer_tree_host()->SetViewportSize(bounds); 147 layer_tree_host()->SetViewportSize(bounds);
148 148
149 blank_layer_ = SolidColorLayer::Create(layer_settings()); 149 blank_layer_ = SolidColorLayer::Create(layer_settings());
150 blank_layer_->SetIsDrawable(true); 150 blank_layer_->SetIsDrawable(true);
151 blank_layer_->SetBounds(gfx::Size(10, 10)); 151 blank_layer_->SetBounds(gfx::Size(10, 10));
152 152
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 // after the layer was removed from the tree, and only once. 202 // after the layer was removed from the tree, and only once.
203 EXPECT_EQ(1u, satisfied[0]); 203 EXPECT_EQ(1u, satisfied[0]);
204 EXPECT_LE(1, commit_count_); 204 EXPECT_LE(1, commit_count_);
205 EXPECT_FALSE(sequence_was_satisfied_); 205 EXPECT_FALSE(sequence_was_satisfied_);
206 sequence_was_satisfied_ = true; 206 sequence_was_satisfied_ = true;
207 EndTest(); 207 EndTest();
208 } 208 }
209 } 209 }
210 210
211 void AfterTest() override { 211 void AfterTest() override {
212 EXPECT_TRUE(required_id_ == SurfaceId(1)); 212 EXPECT_TRUE(required_id_ == SurfaceId::FromUnsafeValue(1));
213 EXPECT_EQ(1u, required_set_.size()); 213 EXPECT_EQ(1u, required_set_.size());
214 // Sequence should have been satisfied through Swap, not with the 214 // Sequence should have been satisfied through Swap, not with the
215 // callback. 215 // callback.
216 EXPECT_TRUE(satisfied_sequence_.is_null()); 216 EXPECT_TRUE(satisfied_sequence_.is_null());
217 } 217 }
218 }; 218 };
219 219
220 // TODO(jbauman): Reenable on single thread once http://crbug.com/421923 is 220 // TODO(jbauman): Reenable on single thread once http://crbug.com/421923 is
221 // fixed. 221 // fixed.
222 MULTI_THREAD_TEST_F(SurfaceLayerSwapPromiseWithDraw); 222 MULTI_THREAD_TEST_F(SurfaceLayerSwapPromiseWithDraw);
(...skipping 20 matching lines...) Expand all
243 case 2: 243 case 2:
244 layer_tree_host()->SetNeedsCommit(); 244 layer_tree_host()->SetNeedsCommit();
245 break; 245 break;
246 default: 246 default:
247 EndTest(); 247 EndTest();
248 break; 248 break;
249 } 249 }
250 } 250 }
251 251
252 void AfterTest() override { 252 void AfterTest() override {
253 EXPECT_TRUE(required_id_ == SurfaceId(1)); 253 EXPECT_TRUE(required_id_ == SurfaceId::FromUnsafeValue(1));
254 EXPECT_EQ(1u, required_set_.size()); 254 EXPECT_EQ(1u, required_set_.size());
255 // Sequence should have been satisfied with the callback. 255 // Sequence should have been satisfied with the callback.
256 EXPECT_TRUE(satisfied_sequence_ == SurfaceSequence(1u, 1u)); 256 EXPECT_TRUE(satisfied_sequence_ == SurfaceSequence(1u, 1u));
257 } 257 }
258 }; 258 };
259 259
260 MULTI_THREAD_TEST_F(SurfaceLayerSwapPromiseWithoutDraw); 260 MULTI_THREAD_TEST_F(SurfaceLayerSwapPromiseWithoutDraw);
261 261
262 } // namespace 262 } // namespace
263 } // namespace cc 263 } // namespace cc
OLDNEW
« no previous file with comments | « cc/layers/surface_layer_impl_unittest.cc ('k') | cc/quads/draw_quad_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698