Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: cc/surfaces/surface_unittest.cc

Issue 1496103002: Reusing base::IdType<...> to implement SurfaceId. Base URL: https://chromium.googlesource.com/chromium/src.git@type-safe-id-base
Patch Set: Rebasing + dusting off... Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_manager.h ('k') | cc/test/surface_aggregator_test_helpers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_unittest.cc
diff --git a/cc/surfaces/surface_unittest.cc b/cc/surfaces/surface_unittest.cc
index 5a9b744fd75dc320129d0be30ac106f4673fb65f..31df308a9a24be497cd2d1cbd2de47c6d2d4aa2f 100644
--- a/cc/surfaces/surface_unittest.cc
+++ b/cc/surfaces/surface_unittest.cc
@@ -35,7 +35,7 @@ TEST(SurfaceTest, SurfaceLifetime) {
FakeSurfaceFactoryClient surface_factory_client;
SurfaceFactory factory(&manager, &surface_factory_client);
- SurfaceId surface_id(6);
+ SurfaceId surface_id = SurfaceId::FromUnsafeValue(6);
{
factory.Create(surface_id);
EXPECT_TRUE(manager.GetSurfaceForId(surface_id));
@@ -50,7 +50,7 @@ TEST(SurfaceTest, StableBeginFrameSourceIndependentOfOrderAdded) {
FakeSurfaceFactoryClient surface_factory_client;
SurfaceFactory factory(&manager, &surface_factory_client);
- SurfaceId surface_id(6);
+ SurfaceId surface_id = SurfaceId::FromUnsafeValue(6);
factory.Create(surface_id);
Surface* surface = manager.GetSurfaceForId(surface_id);
@@ -138,7 +138,7 @@ TEST(SurfaceTest, BeginFrameSourceRemovedOnSurfaceDestruction) {
SurfaceFactory factory(&manager, &surface_factory_client);
FakeBeginFrameSource bfs;
- SurfaceId surface_id(6);
+ SurfaceId surface_id = SurfaceId::FromUnsafeValue(6);
factory.Create(surface_id);
Surface* surface = manager.GetSurfaceForId(surface_id);
surface->AddBeginFrameSource(&bfs);
« no previous file with comments | « cc/surfaces/surface_manager.h ('k') | cc/test/surface_aggregator_test_helpers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698