Reusing base::IdType<...> to implement SurfaceId.

cc/surfaces/surface_aggregator_unittest.cc

Index: cc/surfaces/surface_aggregator_unittest.cc
diff --git a/cc/surfaces/surface_aggregator_unittest.cc b/cc/surfaces/surface_aggregator_unittest.cc
index 95f02611369f887fc1faa8aef02e87aca3775656..aedea62e0a16e682793183637ee39ed31621a2ab 100644
--- a/cc/surfaces/surface_aggregator_unittest.cc
+++ b/cc/surfaces/surface_aggregator_unittest.cc
@@ -7,6 +7,7 @@
 #include <stddef.h>
 #include <stdint.h>
 
+#include <limits>
 #include <utility>
 
 #include "base/macros.h"
@@ -37,9 +38,7 @@ namespace cc {
 namespace {
 
 SurfaceId InvalidSurfaceId() {
-  static SurfaceId invalid;
-  invalid.id = static_cast<uint64_t>(-1);
-  return invalid;
+  return SurfaceId::FromUnsafeValue(std::numeric_limits<uint64_t>::max());
 }
 
 gfx::Size SurfaceSize() {
@@ -103,7 +102,7 @@ class SurfaceAggregatorTest : public testing::Test {
 };
 
 TEST_F(SurfaceAggregatorTest, ValidSurfaceNoFrame) {
-  SurfaceId one_id(7);
+  SurfaceId one_id = SurfaceId::FromUnsafeValue(7);
   factory_.Create(one_id);
   Surface* surface = manager_.GetSurfaceForId(one_id);
 
@@ -1931,7 +1930,7 @@ void SubmitCompositorFrameWithResources(ResourceId* resource_ids,
 TEST_F(SurfaceAggregatorWithResourcesTest, TakeResourcesOneSurface) {
   ResourceTrackingSurfaceFactoryClient client;
   SurfaceFactory factory(&manager_, &client);
-  SurfaceId surface_id(7u);
+  SurfaceId surface_id = SurfaceId::FromUnsafeValue(7u);
   factory.Create(surface_id);
   Surface* surface = manager_.GetSurfaceForId(surface_id);
 
@@ -1970,7 +1969,7 @@ TEST_F(SurfaceAggregatorWithResourcesTest, TakeResourcesOneSurface) {
 TEST_F(SurfaceAggregatorWithResourcesTest, TakeInvalidResources) {
   ResourceTrackingSurfaceFactoryClient client;
   SurfaceFactory factory(&manager_, &client);
-  SurfaceId surface_id(7u);
+  SurfaceId surface_id = SurfaceId::FromUnsafeValue(7u);
   factory.Create(surface_id);
   Surface* surface = manager_.GetSurfaceForId(surface_id);
 
@@ -2010,11 +2009,11 @@ TEST_F(SurfaceAggregatorWithResourcesTest, TakeInvalidResources) {
 TEST_F(SurfaceAggregatorWithResourcesTest, TwoSurfaces) {
   ResourceTrackingSurfaceFactoryClient client;
   SurfaceFactory factory(&manager_, &client);
-  SurfaceId surface1_id(7u);
+  SurfaceId surface1_id = SurfaceId::FromUnsafeValue(7u);
   factory.Create(surface1_id);
   Surface* surface1 = manager_.GetSurfaceForId(surface1_id);
 
-  SurfaceId surface2_id(8u);
+  SurfaceId surface2_id = SurfaceId::FromUnsafeValue(8u);
   factory.Create(surface2_id);
   Surface* surface2 = manager_.GetSurfaceForId(surface2_id);
 
@@ -2065,13 +2064,13 @@ TEST_F(SurfaceAggregatorWithResourcesTest, TwoSurfaces) {
 TEST_F(SurfaceAggregatorWithResourcesTest, InvalidChildSurface) {
   ResourceTrackingSurfaceFactoryClient client;
   SurfaceFactory factory(&manager_, &client);
-  SurfaceId root_surface_id(7u);
+  SurfaceId root_surface_id = SurfaceId::FromUnsafeValue(7u);
   factory.Create(root_surface_id);
   Surface* root_surface = manager_.GetSurfaceForId(root_surface_id);
-  SurfaceId middle_surface_id(8u);
+  SurfaceId middle_surface_id = SurfaceId::FromUnsafeValue(8u);
   factory.Create(middle_surface_id);
   Surface* middle_surface = manager_.GetSurfaceForId(middle_surface_id);
-  SurfaceId child_surface_id(9u);
+  SurfaceId child_surface_id = SurfaceId::FromUnsafeValue(9u);
   factory.Create(child_surface_id);
   Surface* child_surface = manager_.GetSurfaceForId(child_surface_id);