Make the webstore inline install dialog be tab-modal

Make the webstore inline install dialog be tab-modal

Also clean up a few minor lint errors while I'm in here.

BUG=550047
Committed: https://crrev.com/0a1c15fecb1240ab909e1431b6127410c3b380e0
Cr-Commit-Position: refs/heads/master@{#363925}

[asargent_no_longer_on_chrome, 2015-12-04 21:31:08]

Description was changed from

==========
Make the webstore inline install dialog be tab-modal

BUG=550047
==========

to

==========
Make the webstore inline install dialog be tab-modal

Also clean up a few minor lint errors while I'm in here. 

BUG=550047
==========

[asargent_no_longer_on_chrome, 2015-12-04 21:31:46]

asargent@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[asargent_no_longer_on_chrome, 2015-12-04 21:31:46]

https://codereview.chromium.org/1496033003/diff/1/chrome/browser/ui/views/ext...
File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
(right):

https://codereview.chromium.org/1496033003/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:116:
constrained_window::ShowWebModalDialogViews(dialog, parent_web_contents);
FYI, the problem I was having with this patch locally when I asked you about it
last week is that I was using CreateWebModalDialogViews(...)->Show() instead of
ShowWebModalDialogViews(...).

[Devlin, 2015-12-04 21:53:06]

lgtm.

https://codereview.chromium.org/1496033003/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_install_prompt.cc (right):

https://codereview.chromium.org/1496033003/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_install_prompt.cc:410: bool
ExtensionInstallPrompt::Prompt::ShouldUseTabModalDialog() const {
Maybe a comment explaining the reasoning?

https://codereview.chromium.org/1496033003/diff/1/chrome/browser/ui/views/ext...
File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
(right):

https://codereview.chromium.org/1496033003/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:116:
constrained_window::ShowWebModalDialogViews(dialog, parent_web_contents);
On 2015/12/04 21:31:46, Antony Sargent wrote:
> FYI, the problem I was having with this patch locally when I asked you about
it
> last week is that I was using CreateWebModalDialogViews(...)->Show() instead
of
> ShowWebModalDialogViews(...). 
> 

Wow.  That's confusing.

https://codereview.chromium.org/1496033003/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:611: if
(prompt_->ShouldUseTabModalDialog())
nitty nit: ternary?

[asargent_no_longer_on_chrome, 2015-12-07 19:25:52]

asargent@chromium.org changed reviewers:
+ finnur@chromium.org

[asargent_no_longer_on_chrome, 2015-12-07 19:25:53]

+finnur for OWNERS review of
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

https://codereview.chromium.org/1496033003/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_install_prompt.cc (right):

https://codereview.chromium.org/1496033003/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_install_prompt.cc:410: bool
ExtensionInstallPrompt::Prompt::ShouldUseTabModalDialog() const {
On 2015/12/04 21:53:06, Devlin wrote:
> Maybe a comment explaining the reasoning?

Done.

https://codereview.chromium.org/1496033003/diff/1/chrome/browser/ui/views/ext...
File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
(right):

https://codereview.chromium.org/1496033003/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:611: if
(prompt_->ShouldUseTabModalDialog())
On 2015/12/04 21:53:06, Devlin wrote:
> nitty nit: ternary?

Done.

[Finnur, 2015-12-07 23:34:26]

Sorry to keep you waiting, I got side-tracked _again_. Been happening quite a
lot today. :)

Anyway, OWNERS LGTM.

PS. Devlin should probably be owner for this as well, doesn't make sense for him
to LG and for me to have to approve it. He's getting more familiar with all this
than me anyway. :)

[asargent_no_longer_on_chrome, 2015-12-08 21:20:46]

The CQ bit was checked by asargent@chromium.org

[asargent_no_longer_on_chrome, 2015-12-08 21:20:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1496033003/#ps20001
(title: "incorporated review suggestions")

[commit-bot: I haz the power, 2015-12-08 21:22:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496033003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496033003/20001

[commit-bot: I haz the power, 2015-12-09 02:25:29]

Description was changed from

==========
Make the webstore inline install dialog be tab-modal

Also clean up a few minor lint errors while I'm in here. 

BUG=550047
==========

to

==========
Make the webstore inline install dialog be tab-modal

Also clean up a few minor lint errors while I'm in here. 

BUG=550047
==========

[commit-bot: I haz the power, 2015-12-09 02:25:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-09 02:26:08]

Description was changed from

==========
Make the webstore inline install dialog be tab-modal

Also clean up a few minor lint errors while I'm in here. 

BUG=550047
==========

to

==========
Make the webstore inline install dialog be tab-modal

Also clean up a few minor lint errors while I'm in here.

BUG=550047

Committed: https://crrev.com/0a1c15fecb1240ab909e1431b6127410c3b380e0
Cr-Commit-Position: refs/heads/master@{#363925}
==========

[commit-bot: I haz the power, 2015-12-09 02:26:09]

Patchset 2 (id:??) landed as
https://crrev.com/0a1c15fecb1240ab909e1431b6127410c3b380e0
Cr-Commit-Position: refs/heads/master@{#363925}