Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Side by Side Diff: chrome/browser/extensions/extension_install_prompt.h

Issue 1496033003: Make the webstore inline install dialog be tab-modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated review suggestions Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_install_prompt.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 // Returns the empty string when there should be no "accept" button. 121 // Returns the empty string when there should be no "accept" button.
122 base::string16 GetAcceptButtonLabel() const; 122 base::string16 GetAcceptButtonLabel() const;
123 base::string16 GetAbortButtonLabel() const; 123 base::string16 GetAbortButtonLabel() const;
124 base::string16 GetPermissionsHeading( 124 base::string16 GetPermissionsHeading(
125 PermissionsType permissions_type) const; 125 PermissionsType permissions_type) const;
126 base::string16 GetRetainedFilesHeading() const; 126 base::string16 GetRetainedFilesHeading() const;
127 base::string16 GetRetainedDevicesHeading() const; 127 base::string16 GetRetainedDevicesHeading() const;
128 128
129 bool ShouldShowPermissions() const; 129 bool ShouldShowPermissions() const;
130 130
131 bool ShouldUseTabModalDialog() const;
132
131 // Getters for webstore metadata. Only populated when the type is 133 // Getters for webstore metadata. Only populated when the type is
132 // INLINE_INSTALL_PROMPT, EXTERNAL_INSTALL_PROMPT, or REPAIR_PROMPT. 134 // INLINE_INSTALL_PROMPT, EXTERNAL_INSTALL_PROMPT, or REPAIR_PROMPT.
133 135
134 // The star display logic replicates the one used by the webstore (from 136 // The star display logic replicates the one used by the webstore (from
135 // components.ratingutils.setFractionalYellowStars). Callers pass in an 137 // components.ratingutils.setFractionalYellowStars). Callers pass in an
136 // "appender", which will be repeatedly called back with the star images 138 // "appender", which will be repeatedly called back with the star images
137 // that they append to the star display area. 139 // that they append to the star display area.
138 typedef void(*StarAppender)(const gfx::ImageSkia*, void*); 140 typedef void(*StarAppender)(const gfx::ImageSkia*, void*);
139 void AppendRatingStars(StarAppender appender, void* data) const; 141 void AppendRatingStars(StarAppender appender, void* data) const;
140 base::string16 GetRatingCount() const; 142 base::string16 GetRatingCount() const;
(...skipping 324 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 Delegate* delegate_; 467 Delegate* delegate_;
466 468
467 // A pre-filled prompt. 469 // A pre-filled prompt.
468 scoped_refptr<Prompt> prompt_; 470 scoped_refptr<Prompt> prompt_;
469 471
470 // Used to show the confirm dialog. 472 // Used to show the confirm dialog.
471 ShowDialogCallback show_dialog_callback_; 473 ShowDialogCallback show_dialog_callback_;
472 }; 474 };
473 475
474 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_ 476 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_install_prompt.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698