chrome/browser/extensions/extension_install_prompt.h - Issue 1496033003: Make the webstore inline install dialog be tab-modal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_prompt.h

Issue 1496033003: Make the webstore inline install dialog be tab-modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated review suggestions Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_install_prompt.h

diff --git a/chrome/browser/extensions/extension_install_prompt.h b/chrome/browser/extensions/extension_install_prompt.h

index f55887782df7a985f5955e816689d25e32dad6d3..492314871cab44730a5141d91133a0a82f8bc24a 100644

--- a/chrome/browser/extensions/extension_install_prompt.h

+++ b/chrome/browser/extensions/extension_install_prompt.h

@@ -128,6 +128,8 @@ class ExtensionInstallPrompt

bool ShouldShowPermissions() const;

+ bool ShouldUseTabModalDialog() const;

// Getters for webstore metadata. Only populated when the type is

// INLINE_INSTALL_PROMPT, EXTERNAL_INSTALL_PROMPT, or REPAIR_PROMPT.

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_install_prompt.cc » ('j') | no next file with comments »