Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3185)

Unified Diff: chrome/browser/extensions/extension_install_prompt.cc

Issue 1496033003: Make the webstore inline install dialog be tab-modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated review suggestions Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_prompt.cc
diff --git a/chrome/browser/extensions/extension_install_prompt.cc b/chrome/browser/extensions/extension_install_prompt.cc
index 9a90a37a8121499141040c9d8b9b96e33f35a7ee..ce874322f86f235114facded3c1d7dcb0a3a4f7f 100644
--- a/chrome/browser/extensions/extension_install_prompt.cc
+++ b/chrome/browser/extensions/extension_install_prompt.cc
@@ -407,6 +407,13 @@ bool ExtensionInstallPrompt::Prompt::ShouldShowPermissions() const {
type_ == POST_INSTALL_PERMISSIONS_PROMPT;
}
+bool ExtensionInstallPrompt::Prompt::ShouldUseTabModalDialog() const {
+ // For inline install, we want the install prompt to be tab modal so that the
+ // dialog is always clearly associated with the page that made the inline
+ // install request.
+ return type_ == INLINE_INSTALL_PROMPT;
+}
+
void ExtensionInstallPrompt::Prompt::AppendRatingStars(
StarAppender appender, void* data) const {
CHECK(appender);

Powered by Google App Engine
This is Rietveld 408576698