Make the webstore inline install dialog be tab-modal

chrome/browser/extensions/extension_install_prompt.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_install_prompt.h"
 
 #include "base/location.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 389 matching lines @@
     const {
   return l10n_util::GetPluralStringFUTF16(
       IDS_EXTENSION_PROMPT_RETAINED_DEVICES, GetRetainedDeviceCount());
 }
 
 bool ExtensionInstallPrompt::Prompt::ShouldShowPermissions() const {
   return GetPermissionCount(ALL_PERMISSIONS) > 0 ||
          type_ == POST_INSTALL_PERMISSIONS_PROMPT;
 }
 
+bool ExtensionInstallPrompt::Prompt::ShouldUseTabModalDialog() const {

[Devlin, 2015/12/04 21:53:06]

Maybe a comment explaining the reasoning?

[asargent_no_longer_on_chrome, 2015/12/07 19:25:53]

Done.

+  return type_ == INLINE_INSTALL_PROMPT;
+}
+
 void ExtensionInstallPrompt::Prompt::AppendRatingStars(
     StarAppender appender, void* data) const {
   CHECK(appender);
   CHECK(AllowWebstoreData(type_));
   int rating_integer = floor(average_rating_);
   double rating_fractional = average_rating_ - rating_integer;
 
   if (rating_fractional > 0.66) {
     rating_integer++;
   }
@@ skipping 508 matching lines @@
   if (show_params_->WasParentDestroyed()) {
     delegate_->InstallUIAbort(false);
     return;
   }
 
   if (show_dialog_callback_.is_null())
     GetDefaultShowDialogCallback().Run(show_params_.get(), delegate_, prompt_);
   else
     show_dialog_callback_.Run(show_params_.get(), delegate_, prompt_);
 }