Issue 149513011: Pass around CSSSelector by reference instead of pointer

Issue 149513011: Pass around CSSSelector by reference instead of pointer (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
adamk

CC:
blink-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, alph+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, ed+blinkwatch_opera.com, lushnikov+blink_chromium.org, yurys+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, aandrey+blink_chromium.org, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Pass around CSSSelector by reference instead of pointer Pass around CSSSelector by reference instead of pointer as it is expected to be non-null. This makes the code look safer and gets rid of unnecessary null-checks. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166101

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+241 lines, -242 lines)			Patch
M	Source/core/css/CSSSelector.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSSelectorList.h	View	2 chunks	+12 lines, -11 lines	0 comments	Download
M	Source/core/css/CSSSelectorList.cpp	View	6 chunks	+17 lines, -18 lines	0 comments	Download
M	Source/core/css/CSSStyleRule.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/ElementRuleCollector.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/RuleFeature.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/css/RuleFeature.cpp	View	6 chunks	+28 lines, -30 lines	0 comments	Download
M	Source/core/css/RuleSet.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/RuleSet.cpp	View	6 chunks	+38 lines, -36 lines	0 comments	Download
M	Source/core/css/SelectorChecker.h	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	Source/core/css/SelectorChecker.cpp	View	19 chunks	+50 lines, -49 lines	0 comments	Download
M	Source/core/css/SelectorCheckerFastPath.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	Source/core/css/SelectorCheckerFastPath.cpp	View	6 chunks	+26 lines, -26 lines	0 comments	Download
M	Source/core/css/SelectorFilter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/SelectorFilter.cpp	View	2 chunks	+16 lines, -16 lines	0 comments	Download
M	Source/core/css/StyleInvalidationAnalysis.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/resolver/StyleResolver.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/CSSSelectorWatch.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/SelectorQuery.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/SelectorQuery.cpp	View	5 chunks	+11 lines, -13 lines	0 comments	Download
M	Source/core/dom/shadow/ElementShadow.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/shadow/SelectRuleFeatureSet.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/shadow/SelectRuleFeatureSet.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/shadow/HTMLContentElement.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/InspectorStyleSheet.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebSelector.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download