Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: Source/core/css/SelectorFilter.h

Issue 149513011: Pass around CSSSelector by reference instead of pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/SelectorCheckerFastPath.cpp ('k') | Source/core/css/SelectorFilter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 void popParentStackFrame(); 43 void popParentStackFrame();
44 44
45 void setupParentStack(Element& parent); 45 void setupParentStack(Element& parent);
46 void pushParent(Element& parent); 46 void pushParent(Element& parent);
47 void popParent() { popParentStackFrame(); } 47 void popParent() { popParentStackFrame(); }
48 bool parentStackIsEmpty() const { return m_parentStack.isEmpty(); } 48 bool parentStackIsEmpty() const { return m_parentStack.isEmpty(); }
49 bool parentStackIsConsistent(const ContainerNode* parentNode) const { return !m_parentStack.isEmpty() && m_parentStack.last().element == parentNode; } 49 bool parentStackIsConsistent(const ContainerNode* parentNode) const { return !m_parentStack.isEmpty() && m_parentStack.last().element == parentNode; }
50 50
51 template <unsigned maximumIdentifierCount> 51 template <unsigned maximumIdentifierCount>
52 inline bool fastRejectSelector(const unsigned* identifierHashes) const; 52 inline bool fastRejectSelector(const unsigned* identifierHashes) const;
53 static void collectIdentifierHashes(const CSSSelector*, unsigned* identifier Hashes, unsigned maximumIdentifierCount); 53 static void collectIdentifierHashes(const CSSSelector&, unsigned* identifier Hashes, unsigned maximumIdentifierCount);
54 54
55 private: 55 private:
56 struct ParentStackFrame { 56 struct ParentStackFrame {
57 ParentStackFrame() : element(0) { } 57 ParentStackFrame() : element(0) { }
58 ParentStackFrame(Element& element) : element(&element) { } 58 ParentStackFrame(Element& element) : element(&element) { }
59 Element* element; 59 Element* element;
60 Vector<unsigned, 4> identifierHashes; 60 Vector<unsigned, 4> identifierHashes;
61 }; 61 };
62 Vector<ParentStackFrame> m_parentStack; 62 Vector<ParentStackFrame> m_parentStack;
63 63
64 // With 100 unique strings in the filter, 2^12 slot table has false positive rate of ~0.2%. 64 // With 100 unique strings in the filter, 2^12 slot table has false positive rate of ~0.2%.
65 static const unsigned bloomFilterKeyBits = 12; 65 static const unsigned bloomFilterKeyBits = 12;
66 OwnPtr<BloomFilter<bloomFilterKeyBits> > m_ancestorIdentifierFilter; 66 OwnPtr<BloomFilter<bloomFilterKeyBits> > m_ancestorIdentifierFilter;
67 }; 67 };
68 68
69 template <unsigned maximumIdentifierCount> 69 template <unsigned maximumIdentifierCount>
70 inline bool SelectorFilter::fastRejectSelector(const unsigned* identifierHashes) const 70 inline bool SelectorFilter::fastRejectSelector(const unsigned* identifierHashes) const
71 { 71 {
72 ASSERT(m_ancestorIdentifierFilter); 72 ASSERT(m_ancestorIdentifierFilter);
73 for (unsigned n = 0; n < maximumIdentifierCount && identifierHashes[n]; ++n) { 73 for (unsigned n = 0; n < maximumIdentifierCount && identifierHashes[n]; ++n) {
74 if (!m_ancestorIdentifierFilter->mayContain(identifierHashes[n])) 74 if (!m_ancestorIdentifierFilter->mayContain(identifierHashes[n]))
75 return true; 75 return true;
76 } 76 }
77 return false; 77 return false;
78 } 78 }
79 79
80 } 80 }
81 81
82 #endif 82 #endif
OLDNEW
« no previous file with comments | « Source/core/css/SelectorCheckerFastPath.cpp ('k') | Source/core/css/SelectorFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698