Source/core/css/RuleSet.h - Issue 149513011: Pass around CSSSelector by reference instead of pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/RuleSet.h

Issue 149513011: Pass around CSSSelector by reference instead of pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/RuleSet.h

diff --git a/Source/core/css/RuleSet.h b/Source/core/css/RuleSet.h

index d8249a3edb96428b519a96886a089282b743663c..9094cf035d19ae78e7117471a1da29c2095031c0 100644

--- a/Source/core/css/RuleSet.h

+++ b/Source/core/css/RuleSet.h

@@ -71,7 +71,7 @@ public:

unsigned position() const { return m_position; }

StyleRule* rule() const { return m_rule; }

- const CSSSelector* selector() const { return m_rule->selectorList().selectorAt(m_selectorIndex); }

+ const CSSSelector& selector() const { return m_rule->selectorList().selectorAt(m_selectorIndex); }

unsigned selectorIndex() const { return m_selectorIndex; }

bool isLastInArray() const { return m_isLastInArray; }

@@ -180,7 +180,7 @@ private:

void addRegionRule(StyleRuleRegion*, bool hasDocumentSecurityOrigin);

void addChildRules(const Vector<RefPtr<StyleRuleBase> >&, const MediaQueryEvaluator& medium, AddRuleFlags);

- bool findBestRuleSetAndAdd(const CSSSelector*, RuleData&);

+ bool findBestRuleSetAndAdd(const CSSSelector&, RuleData&);

void compactRules();

static void compactPendingRules(PendingRuleMap&, CompactRuleMap&);

« no previous file with comments | « Source/core/css/RuleFeature.cpp ('k') | Source/core/css/RuleSet.cpp » ('j') | no next file with comments »