Source/core/css/ElementRuleCollector.cpp - Issue 149513011: Pass around CSSSelector by reference instead of pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/ElementRuleCollector.cpp

Issue 149513011: Pass around CSSSelector by reference instead of pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/ElementRuleCollector.cpp

diff --git a/Source/core/css/ElementRuleCollector.cpp b/Source/core/css/ElementRuleCollector.cpp

index 66036b00ca3f603063beb90ebe945d5270f8b2f3..9f32c3fbd7667f25bbfdc73550df369d40034c6d 100644

--- a/Source/core/css/ElementRuleCollector.cpp

+++ b/Source/core/css/ElementRuleCollector.cpp

@@ -286,7 +286,7 @@ inline bool ElementRuleCollector::ruleMatches(const RuleData& ruleData, const Co

if (!ruleData.hasMultipartSelector())

return true;

}

- if (ruleData.selector()->m_match == CSSSelector::Tag && !SelectorChecker::tagMatches(*m_context.element(), ruleData.selector()->tagQName()))

+ if (ruleData.selector().m_match == CSSSelector::Tag && !SelectorChecker::tagMatches(*m_context.element(), ruleData.selector().tagQName()))

return false;

SelectorCheckerFastPath selectorCheckerFastPath(ruleData.selector(), *m_context.element());

if (!selectorCheckerFastPath.matchesRightmostAttributeSelector())

« no previous file with comments | « Source/core/css/CSSStyleRule.cpp ('k') | Source/core/css/RuleFeature.h » ('j') | no next file with comments »