Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: Source/web/WebSelector.cpp

Issue 149513011: Pass around CSSSelector by reference instead of pointer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/inspector/InspectorStyleSheet.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 29 matching lines...) Expand all
40 namespace blink { 40 namespace blink {
41 41
42 WebString canonicalizeSelector(WebString webSelector, WebSelectorType restrictio n) 42 WebString canonicalizeSelector(WebString webSelector, WebSelectorType restrictio n)
43 { 43 {
44 CSSParserContext context(HTMLStandardMode); 44 CSSParserContext context(HTMLStandardMode);
45 BisonCSSParser parser(context); 45 BisonCSSParser parser(context);
46 CSSSelectorList selectorList; 46 CSSSelectorList selectorList;
47 parser.parseSelector(webSelector, selectorList); 47 parser.parseSelector(webSelector, selectorList);
48 48
49 if (restriction == WebSelectorTypeCompound) { 49 if (restriction == WebSelectorTypeCompound) {
50 for (const CSSSelector* selector = selectorList.first(); selector; selec tor = selectorList.next(selector)) { 50 for (const CSSSelector* selector = selectorList.first(); selector; selec tor = selectorList.next(*selector)) {
51 if (!selector->isCompound()) 51 if (!selector->isCompound())
52 return WebString(); 52 return WebString();
53 } 53 }
54 } 54 }
55 return selectorList.selectorsText(); 55 return selectorList.selectorsText();
56 } 56 }
57 57
58 } // namespace blink 58 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorStyleSheet.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698