HTMLInputElement.valueAsNumber compliance (NaN handling.)

HTMLInputElement.valueAsNumber compliance (NaN handling.)

Change the valueAsNumber setter to follow the spec more closely:

 http://www.whatwg.org/specs/web-apps/current-work/#dom-input-valueasnumber

 - throw TypeError instead of NotSupportedError if the new value is
   infinite.
 - if the input element type supports 'valueAsNumber', then no longer
   throw for NaN values, but consider this as setting the empty
   string.
 - better InvalidStateError error message when attempting to update
   'valueAsNumber'.

This aligns with the spec as well as Gecko. And Trident (IE11) with
respect to NaN handling.

R=mkwst@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166112

[sof, 2014-01-29 11:00:12]

When you next have a spare moment, please take a look.

[Mike West, 2014-01-29 19:31:36]

LGTM with one question.

https://codereview.chromium.org/149413004/diff/1/Source/core/html/forms/BaseD...
File Source/core/html/forms/BaseDateAndTimeInputType.cpp (right):

https://codereview.chromium.org/149413004/diff/1/Source/core/html/forms/BaseD...
Source/core/html/forms/BaseDateAndTimeInputType.cpp:67: void
BaseDateAndTimeInputType::setValueAsDouble(double newValue,
TextFieldEventBehavior eventBehavior, ExceptionState& exceptionState) const
Why did this change from `Decimal` to `double`?

[sof, 2014-01-29 19:53:41]

Thanks for having a close look.

I'll sit on this one overnight so that tkent may have a chance to look at the
code re-arrangments made.

https://codereview.chromium.org/149413004/diff/1/Source/core/html/forms/BaseD...
File Source/core/html/forms/BaseDateAndTimeInputType.cpp (right):

https://codereview.chromium.org/149413004/diff/1/Source/core/html/forms/BaseD...
Source/core/html/forms/BaseDateAndTimeInputType.cpp:67: void
BaseDateAndTimeInputType::setValueAsDouble(double newValue,
TextFieldEventBehavior eventBehavior, ExceptionState& exceptionState) const
On 2014/01/29 19:31:37, Mike West wrote:
> Why did this change from `Decimal` to `double`?

Good question, not sure I have a succinct answer, but let me try to explain:

- The setValueAsDouble() and setValueAsDate() methods on the base class
InputType now throw InvalidStateErrors to indicate non-support for setting
either property.

- Anything date-related will as a consequence have to override
setValueAsNumber() (and setValueAsDate()), as they support both properties
(well... datetime-local is the odd one out.) Which explains the
setValueAsDouble() override added here.

- InputType::setValueAsDecimal() used to throw; there's no good reason why it
should any longer, hence I made it perform the usual serialization of the
incoming Decimal value. Consequently, BaseDateAndTimeInputType no longer needs
to override setValueAsDecimal(), but can rely on the base implementation
provided by InputType.

[tkent, 2014-01-30 01:11:41]

lgtm

[commit-bot: I haz the power, 2014-01-30 01:11:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/149413004/1

[commit-bot: I haz the power, 2014-01-30 08:16:39]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-30 08:26:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/149413004/1

[commit-bot: I haz the power, 2014-01-30 09:35:09]

Change committed as 166112

[commit-bot: I haz the power, 2014-01-30 09:36:06]

CQ bit was unchecked on CL. Ignoring.