Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: LayoutTests/fast/forms/time/time-valueasnumber.html

Issue 149413004: HTMLInputElement.valueAsNumber compliance (NaN handling.) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/forms/time/time-valueasnumber.html
diff --git a/LayoutTests/fast/forms/time/time-valueasnumber.html b/LayoutTests/fast/forms/time/time-valueasnumber.html
index 8de0d32914a5d5927e49429d4a6da843215e6aa3..152fcf56995c3368421cbb6b9720e9cb2ac233d8 100644
--- a/LayoutTests/fast/forms/time/time-valueasnumber.html
+++ b/LayoutTests/fast/forms/time/time-valueasnumber.html
@@ -39,12 +39,15 @@ shouldBe('setValueAsNumberAndGetValue(-23, -59, -59, 0)', '"00:00:01"');
debug('Tests to set invalid values to valueAsNumber:');
shouldBe('input.value = ""; input.valueAsNumber = null; input.value', '"00:00"');
-shouldThrow('input.valueAsNumber = "foo"', '"NotSupportedError: Failed to set the \'valueAsNumber\' property on \'HTMLInputElement\': The value provided is not a number."');
-shouldThrow('input.valueAsNumber = NaN', '"NotSupportedError: Failed to set the \'valueAsNumber\' property on \'HTMLInputElement\': The value provided is not a number."');
-shouldThrow('input.valueAsNumber = Number.NaN', '"NotSupportedError: Failed to set the \'valueAsNumber\' property on \'HTMLInputElement\': The value provided is not a number."');
-shouldThrow('input.valueAsNumber = Infinity', '"NotSupportedError: Failed to set the \'valueAsNumber\' property on \'HTMLInputElement\': The value provided is infinite."');
-shouldThrow('input.valueAsNumber = Number.POSITIVE_INFINITY', '"NotSupportedError: Failed to set the \'valueAsNumber\' property on \'HTMLInputElement\': The value provided is infinite."');
-shouldThrow('input.valueAsNumber = Number.NEGATIVE_INFINITY', '"NotSupportedError: Failed to set the \'valueAsNumber\' property on \'HTMLInputElement\': The value provided is infinite."');
+shouldBeNaN('input.valueAsNumber = "foo"; input.valueAsNumber');
+shouldBeEqualToString('input.valueAsNumber = "foo"; input.value', '');
+shouldBeNaN('input.valueAsNumber = NaN; input.valueAsNumber');
+shouldBeEqualToString('input.valueAsNumber = NaN; input.value', '');
+shouldBeNaN('input.valueAsNumber = Number.NaN; input.valueAsNumber');
+shouldBeEqualToString('input.valueAsNumber = Number.NaN; input.value', '');
+shouldThrow('input.valueAsNumber = Infinity', '"TypeError: Failed to set the \'valueAsNumber\' property on \'HTMLInputElement\': The value provided is infinite."');
+shouldThrow('input.valueAsNumber = Number.POSITIVE_INFINITY', '"TypeError: Failed to set the \'valueAsNumber\' property on \'HTMLInputElement\': The value provided is infinite."');
+shouldThrow('input.valueAsNumber = Number.NEGATIVE_INFINITY', '"TypeError: Failed to set the \'valueAsNumber\' property on \'HTMLInputElement\': The value provided is infinite."');
debug('Step attribute value and string representation:');
// If the step attribute value is 1 second and the second part is 0, we should show the second part.

Powered by Google App Engine
This is Rietveld 408576698