Source/core/html/HTMLInputElement.cpp - Issue 149413004: HTMLInputElement.valueAsNumber compliance (NaN handling.)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 149413004: HTMLInputElement.valueAsNumber compliance (NaN handling.) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/week/input-valueasnumber-week-expected.txt ('k') | Source/core/html/forms/BaseDateAndTimeInputType.h » ('j') | Source/core/html/forms/BaseDateAndTimeInputType.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index 80cda11bbe2e11fa7bf55f2af3aa5c9d85a2d3da..6e6a03f6b0d66043b0cd4a0a2032c16aff471547 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -1055,8 +1055,8 @@ double HTMLInputElement::valueAsNumber() const

void HTMLInputElement::setValueAsNumber(double newValue, ExceptionState& exceptionState, TextFieldEventBehavior eventBehavior)

{

- if (!std::isfinite(newValue)) {

- exceptionState.throwDOMException(NotSupportedError, ExceptionMessages::notAFiniteNumber(newValue));

+ if (std::isinf(newValue)) {

+ exceptionState.throwTypeError(ExceptionMessages::notAFiniteNumber(newValue));

return;

}

m_inputType->setValueAsDouble(newValue, eventBehavior, exceptionState);