Source/core/html/forms/BaseDateAndTimeInputType.h - Issue 149413004: HTMLInputElement.valueAsNumber compliance (NaN handling.)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/BaseDateAndTimeInputType.h

Issue 149413004: HTMLInputElement.valueAsNumber compliance (NaN handling.) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/forms/BaseDateAndTimeInputType.cpp » ('j') | Source/core/html/forms/BaseDateAndTimeInputType.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/BaseDateAndTimeInputType.h

diff --git a/Source/core/html/forms/BaseDateAndTimeInputType.h b/Source/core/html/forms/BaseDateAndTimeInputType.h

index 370e9bfa196d548b29a37709a5892ce91bcaba80..bf5c8bf895a5bcef214caec1b7832bfb8aac5414 100644

--- a/Source/core/html/forms/BaseDateAndTimeInputType.h

+++ b/Source/core/html/forms/BaseDateAndTimeInputType.h

@@ -59,7 +59,7 @@ private:

virtual double valueAsDate() const OVERRIDE;

virtual void setValueAsDate(double, ExceptionState&) const OVERRIDE;

virtual double valueAsDouble() const OVERRIDE;

- virtual void setValueAsDecimal(const Decimal&, TextFieldEventBehavior, ExceptionState&) const OVERRIDE;

+ virtual void setValueAsDouble(double, TextFieldEventBehavior, ExceptionState&) const OVERRIDE;

virtual bool typeMismatchFor(const String&) const OVERRIDE;

virtual bool typeMismatch() const OVERRIDE;

virtual bool valueMissing(const String&) const OVERRIDE;