HTMLInputElement.valueAsNumber compliance (NaN handling.)

Source/core/html/forms/BaseDateAndTimeInputType.cpp

Index: Source/core/html/forms/BaseDateAndTimeInputType.cpp
diff --git a/Source/core/html/forms/BaseDateAndTimeInputType.cpp b/Source/core/html/forms/BaseDateAndTimeInputType.cpp
index bf87e948cc0f52c30c0bc49b9912411dd1313c28..6868f8a56a415585809f3d5f1134a54a26256a55 100644
--- a/Source/core/html/forms/BaseDateAndTimeInputType.cpp
+++ b/Source/core/html/forms/BaseDateAndTimeInputType.cpp
@@ -64,9 +64,9 @@ double BaseDateAndTimeInputType::valueAsDouble() const
     return value.isFinite() ? value.toDouble() : DateComponents::invalidMilliseconds();
 }
 
-void BaseDateAndTimeInputType::setValueAsDecimal(const Decimal& newValue, TextFieldEventBehavior eventBehavior, ExceptionState&) const
+void BaseDateAndTimeInputType::setValueAsDouble(double newValue, TextFieldEventBehavior eventBehavior, ExceptionState& exceptionState) const

[Mike West, 2014/01/29 19:31:37]

Why did this change from `Decimal` to `double`?

[sof, 2014/01/29 19:53:41]

Good question, not sure I have a succinct answer, but let me try to explain:

- The setValueAsDouble() and setValueAsDate() methods on the base class
InputType now throw InvalidStateErrors to indicate non-support for setting
either property.

- Anything date-related will as a consequence have to override
setValueAsNumber() (and setValueAsDate()), as they support both properties
(well... datetime-local is the odd one out.) Which explains the
setValueAsDouble() override added here.

- InputType::setValueAsDecimal() used to throw; there's no good reason why it
should any longer, hence I made it perform the usual serialization of the
incoming Decimal value. Consequently, BaseDateAndTimeInputType no longer needs
to override setValueAsDecimal(), but can rely on the base implementation
provided by InputType.

 {
-    element().setValue(serialize(newValue), eventBehavior);
+    setValueAsDecimal(Decimal::fromDouble(newValue), eventBehavior, exceptionState);
 }
 
 bool BaseDateAndTimeInputType::typeMismatchFor(const String& value) const