MIPS:[turbofan] Use Ins, Dins to clear bits instead of And with inverted immediate.

MIPS:[turbofan] Use Ins, Dins to clear bits instead of And with inverted immediate.

TEST=unittests/InstructionSelectorTest.Word(32|64)AndToClearBits
BUG=

Committed: https://crrev.com/2d0e9abebfec9923f03d823c3ff63ad0bb4cd42d
Cr-Commit-Position: refs/heads/master@{#32479}

[dusan.milosavljevic, 2015-12-01 15:03:14]

dusan.m.milosavljevic@gmail.com changed reviewers:
+ balazs.kilvady@imgtec.com, bmeurer@chromium.org, jkummerow@chromium.org,
paul.lind@imgtec.com, titzer@chromium.org

[dusan.milosavljevic, 2015-12-01 15:03:15]

PTAL.

[paul.l..., 2015-12-01 17:49:34]

LGTM, modulo nits.

https://codereview.chromium.org/1485023004/diff/1/src/compiler/mips/instructi...
File src/compiler/mips/instruction-selector-mips.cc (right):

https://codereview.chromium.org/1485023004/diff/1/src/compiler/mips/instructi...
src/compiler/mips/instruction-selector-mips.cc:293: // and remove constant
loading of invereted mask.
nit: spelling of inverted.

https://codereview.chromium.org/1485023004/diff/1/src/compiler/mips64/instruc...
File src/compiler/mips64/instruction-selector-mips64.cc (right):

https://codereview.chromium.org/1485023004/diff/1/src/compiler/mips64/instruc...
src/compiler/mips64/instruction-selector-mips64.cc:304: // and remove constant
loading of invereted mask.
nit, inverted. Optional: maybe a comment mentioning DINS instruction is limited
to inserting within low 32-bits only? The code is right, but initial expectation
is that K could be up to 63. (And, if those cases were at all common in
practice, we could add DINSM, DINSU instructions. Might still be less than
loading 64-bit constant.)

[dusan.milosavljevic, 2015-12-01 21:55:54]

https://codereview.chromium.org/1485023004/diff/1/src/compiler/mips64/instruc...
File src/compiler/mips64/instruction-selector-mips64.cc (right):

https://codereview.chromium.org/1485023004/diff/1/src/compiler/mips64/instruc...
src/compiler/mips64/instruction-selector-mips64.cc:304: // and remove constant
loading of invereted mask.
On 2015/12/01 17:49:34, paul.l... wrote:
> nit, inverted. Optional: maybe a comment mentioning DINS instruction is
limited
> to inserting within low 32-bits only? The code is right, but initial
expectation
> is that K could be up to 63. (And, if those cases were at all common in
> practice, we could add DINSM, DINSU instructions. Might still be less than
> loading 64-bit constant.)

Done.

[dusan.milosavljevic, 2015-12-01 21:56:03]

The CQ bit was checked by dusan.m.milosavljevic@gmail.com

[dusan.milosavljevic, 2015-12-01 21:56:03]

The patchset sent to the CQ was uploaded after l-g-t-m from paul.lind@imgtec.com
Link to the patchset: https://codereview.chromium.org/1485023004/#ps20001
(title: "Fix comments.")

[commit-bot: I haz the power, 2015-12-01 21:56:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1485023004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1485023004/20001

[commit-bot: I haz the power, 2015-12-01 22:16:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-01 22:16:55]

Description was changed from

==========
MIPS:[turbofan] Use Ins, Dins to clear bits instead of And with inverted
immediate.

TEST=unittests/InstructionSelectorTest.Word(32|64)AndToClearBits
BUG=
==========

to

==========
MIPS:[turbofan] Use Ins, Dins to clear bits instead of And with inverted
immediate.

TEST=unittests/InstructionSelectorTest.Word(32|64)AndToClearBits
BUG=

Committed: https://crrev.com/2d0e9abebfec9923f03d823c3ff63ad0bb4cd42d
Cr-Commit-Position: refs/heads/master@{#32479}
==========

[commit-bot: I haz the power, 2015-12-01 22:16:56]

Patchset 2 (id:??) landed as
https://crrev.com/2d0e9abebfec9923f03d823c3ff63ad0bb4cd42d
Cr-Commit-Position: refs/heads/master@{#32479}