new DartCompletionPlugin

- move completion contributor extension into new DartCompletionPlugin
- change DartCompletionContributorFactor to return single contributor rather than list of contributors
- remove server field from completion request
- update comments per prior review

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/6fb4f45d6b86e5e215db1769588633f46d2fae75

[danrubel, 2015-11-30 17:49:37]

Description was changed from

==========
- move completion contributor extension into new DartCompletionPlugin
- change DartCompletionContributorFactor to return single contributor rather
than list of contributors
- remove server field from completion request
- update comments per prior review
==========

to

==========
- move completion contributor extension into new DartCompletionPlugin
- change DartCompletionContributorFactor to return single contributor rather
than list of contributors
- remove server field from completion request
- update comments per prior review
==========

[danrubel, 2015-11-30 17:50:28]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2015-11-30 18:10:27]

LGTM

https://codereview.chromium.org/1484853002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart
(right):

https://codereview.chromium.org/1484853002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart:15:
final DartCompletionPlugin dartCompletionPlugin = new DartCompletionPlugin();
I'm not thrilled about having a global variable, but maybe it's better to be
honest than try to hide it as a static field or even an instance field in a
unique object...

https://codereview.chromium.org/1484853002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart:17:
class DartCompletionPlugin implements Plugin {
What's the value of pulling this out to a separate plugin? (I don't have a
strong objection, mostly wanting to know whether the same logic should be
applied elsewhere.)

[danrubel, 2015-11-30 18:53:26]

Description was changed from

==========
- move completion contributor extension into new DartCompletionPlugin
- change DartCompletionContributorFactor to return single contributor rather
than list of contributors
- remove server field from completion request
- update comments per prior review
==========

to

==========
- move completion contributor extension into new DartCompletionPlugin
- change DartCompletionContributorFactor to return single contributor rather
than list of contributors
- remove server field from completion request
- update comments per prior review

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6fb4f45d6b86e5e215db1769588633f46d2fae75
==========

[danrubel, 2015-11-30 18:53:28]

Committed patchset #1 (id:1) manually as
6fb4f45d6b86e5e215db1769588633f46d2fae75 (presubmit successful).

[danrubel, 2015-11-30 18:53:39]

https://codereview.chromium.org/1484853002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart
(right):

https://codereview.chromium.org/1484853002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart:15:
final DartCompletionPlugin dartCompletionPlugin = new DartCompletionPlugin();
On 2015/11/30 18:10:27, Brian Wilkerson wrote:
> I'm not thrilled about having a global variable, but maybe it's better to be
> honest than try to hide it as a static field or even an instance field in a
> unique object...

The linter plugin does this as well. If we have a better approach, then we can
apply it there as well.

https://codereview.chromium.org/1484853002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart:17:
class DartCompletionPlugin implements Plugin {
On 2015/11/30 18:10:27, Brian Wilkerson wrote:
> What's the value of pulling this out to a separate plugin? (I don't have a
> strong objection, mostly wanting to know whether the same logic should be
> applied elsewhere.)

There will be a top level CompletionContributor extension point. The
DartCompletionManager will be one of several completion contributors (e.g.
AngularCompletionManager, HtmlCompletionManager) which provide their own
extension points. I'm implementing DartCompletionPlugin and
DartCompletionManager along these lines to prove the infrastructure and provide
a pattern for others.

[Brian Wilkerson, 2015-11-30 19:02:01]

https://codereview.chromium.org/1484853002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart
(right):

https://codereview.chromium.org/1484853002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart:17:
class DartCompletionPlugin implements Plugin {
> There will be a top level CompletionContributor extension point.

I assume that will be in the server plugin, in which case I now understand.