Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: pkg/analysis_server/lib/src/provisional/completion/completion_core.dart

Issue 1484853002: new DartCompletionPlugin (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
diff --git a/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart b/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
index 5158e6024ae00b161e2dd83d77a2d5200a826c0d..d8567f79139e072333e85da77b89ba6669ccab46 100644
--- a/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
+++ b/pkg/analysis_server/lib/src/provisional/completion/completion_core.dart
@@ -7,8 +7,7 @@ library analysis_server.src.provisional.completion.completion_core;
import 'dart:async';
import 'package:analysis_server/plugin/protocol/protocol.dart';
-import 'package:analysis_server/src/analysis_server.dart';
-import 'package:analysis_server/src/plugin/server_plugin.dart';
+import 'package:analysis_server/src/services/search/search_engine.dart';
import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;
import 'package:analyzer/src/generated/source.dart';
@@ -40,16 +39,6 @@ abstract class CompletionContributor {
*/
abstract class CompletionRequest {
/**
- * Return the underlying analysis server for this completion request.
- */
- AnalysisServer get server;
-
- /**
- * Return the [AnalysisServer]'s [ServerPlugin] for obtaining extensions
- */
- ServerPlugin get serverPlugin;
-
- /**
* Return the analysis context in which the completion is being requested.
*/
AnalysisContext get context;
@@ -66,6 +55,11 @@ abstract class CompletionRequest {
ResourceProvider get resourceProvider;
/**
+ * Return the search engine.
+ */
+ SearchEngine get searchEngine;
+
+ /**
* Return the source in which the completion is being requested.
*/
Source get source;

Powered by Google App Engine
This is Rietveld 408576698