pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart - Issue 1484853002: new DartCompletionPlugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart

Issue 1484853002: new DartCompletionPlugin (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart ('K') | « pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart

diff --git a/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart b/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart

index 95cbb70bebb430fee9e4876c58c68ac0c87766d5..54ad5e1d3f51cf6d3850637648bbead1fac8da55 100644

--- a/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart

+++ b/pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart

@@ -8,7 +8,6 @@ import 'package:analysis_server/plugin/protocol/protocol.dart' as protocol

show Element, ElementKind;

import 'package:analysis_server/plugin/protocol/protocol.dart'

hide Element, ElementKind;

-import 'package:analysis_server/src/analysis_server.dart';

import 'package:analysis_server/src/services/completion/dart_completion_cache.dart';

import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';

import 'package:analysis_server/src/services/completion/imported_reference_contributor.dart';

@@ -20,7 +19,6 @@ import 'package:test_reflective_loader/test_reflective_loader.dart';

import 'package:unittest/unittest.dart';

import '../../abstract_context.dart';

-import '../../operation/operation_queue_test.dart';

import '../../utils.dart';

import 'completion_test_util.dart';

@@ -64,13 +62,12 @@ class ImportedReferenceContributorTest extends AbstractSelectorSuggestionTest {

setUpContributor();

int replacementOffset = request.replacementOffset;

int replacementLength = request.replacementLength;

- AnalysisServer server = new AnalysisServerMock();

* Pass null for searchEngine to ensure that it is not used

* when the cache has been populated.

request = new DartCompletionRequest(

- server, context, testSource, completionOffset, cache);

+ context, provider, searchEngine, testSource, completionOffset, cache);

request.replacementOffset = replacementOffset;

request.replacementLength = replacementLength;