Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart

Issue 1484853002: new DartCompletionPlugin (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart
diff --git a/pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart b/pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart
index d2fa896b64d87372c8e2a679bad6b481ad3b6cac..eba1e5e0f80e271ae915db3eadab72ed50ca9c94 100644
--- a/pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart
+++ b/pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart
@@ -3,32 +3,31 @@
// BSD-style license that can be found in the LICENSE file.
/**
- * Support for client code that extends the analysis server by adding new code
+ * Support for client code that extends the analysis server by adding new
* Dart specific completion contributors.
*
* Plugins can register Dart specific completion contributor factories.
- * The registered contributor factoriess will be used to instantiate new
+ * The registered contributor factories will be used to instantiate new
* contributors to get completions any time a client issues
* a 'completion.getSuggestions' request.
*
- * If a plugin wants to add completions, it should implement the class
- * [DartCompletionContributorFactory] and then register the contributor
- * by including code like the following in the plugin's
- * registerExtensions method:
+ * If a plugin wants to add completions, it should implement
+ * [DartCompletionContributorFactory] by including code
+ * like the following in the plugin's registerExtensions method:
*
* @override
* void registerExtensions(RegisterExtension registerExtension) {
* ...
* registerExtension(
* DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID,
- * () => [new MyDartCompletionContributor()]);
+ * () => new MyDartCompletionContributor());
* ...
* }
*/
library analysis_server.src.provisional.completion.completion;
-import 'package:analysis_server/src/plugin/server_plugin.dart';
import 'package:analysis_server/src/provisional/completion/dart/completion_dart.dart';
+import 'package:analysis_server/src/provisional/completion/dart/completion_plugin.dart';
import 'package:plugin/plugin.dart';
/**
@@ -37,5 +36,5 @@ import 'package:plugin/plugin.dart';
* [DartCompletionContributor].
*/
final String DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT_ID = Plugin.join(
- ServerPlugin.UNIQUE_IDENTIFIER,
- ServerPlugin.DART_COMPLETION_CONTRIBUTOR_EXTENSION_POINT);
+ DartCompletionPlugin.UNIQUE_IDENTIFIER,
+ DartCompletionPlugin.CONTRIBUTOR_EXTENSION_POINT);

Powered by Google App Engine
This is Rietveld 408576698