pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart - Issue 1484853002: new DartCompletionPlugin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart

Issue 1484853002: new DartCompletionPlugin (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart ('k') | pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart » ('j') | pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart

diff --git a/pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart b/pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart

index cff1800191865a2c9d1f338ca6fd3d031cb5a0fe..ebd551836620326bf8cfadd2f6d3c7796ffdb6c1 100644

--- a/pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart

+++ b/pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart

@@ -32,11 +32,11 @@ const int DART_RELEVANCE_NAMED_PARAMETER = 1060;

const int DART_RELEVANCE_PARAMETER = 1059;

/**

- * An object used to instantiate [DartCompletionContributor] instances

+ * An object used to instantiate a [DartCompletionContributor] instance

* for each 'completion.getSuggestions' request.

* Contributors should *not* be cached between requests.

-typedef List<DartCompletionContributor> DartCompletionContributorFactory();

+typedef DartCompletionContributor DartCompletionContributorFactory();

/**

* An object used to produce completions