Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 14824006: Revert 198820 "Move FileEnumerator to its own file, do some refa..." (Closed)

Created:
7 years, 7 months ago by Dan Beam
Modified:
7 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 198820 "Move FileEnumerator to its own file, do some refa..." Broke both windows clobber and official builders' compile with this error: 771>Link: 771> Creating library ..\..\..\build\Release\lib\gcp_portmon64.lib and object ..\..\..\build\Release\lib\gcp_portmon64.exp 771>base.lib(path_service.obj) : fatalerror LNK1112: module machine type 'X86' conflicts with target machine type 'x64' 771> 771>Build FAILED. > Move FileEnumerator to its own file, do some refactoring. > > It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. > > BUG=175002 > R=rvargas@chromium.org > > Review URL: https://codereview.chromium.org/13165005 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+913 lines, -974 lines) Patch
M trunk/src/base/base.gypi View 2 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/base/file_util.h View 3 chunks +111 lines, -3 lines 0 comments Download
M trunk/src/base/file_util.cc View 4 chunks +24 lines, -5 lines 0 comments Download
M trunk/src/base/file_util_posix.cc View 10 chunks +165 lines, -13 lines 0 comments Download
M trunk/src/base/file_util_unittest.cc View 14 chunks +22 lines, -20 lines 0 comments Download
M trunk/src/base/file_util_win.cc View 1 chunk +133 lines, -0 lines 0 comments Download
D trunk/src/base/files/file_enumerator.h View 1 chunk +0 lines, -156 lines 0 comments Download
D trunk/src/base/files/file_enumerator.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D trunk/src/base/files/file_enumerator_posix.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D trunk/src/base/files/file_enumerator_win.cc View 1 chunk +0 lines, -149 lines 0 comments Download
M trunk/src/base/test/test_file_util_posix.cc View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/camera_detector.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/contacts/contact_database_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/drive/file_cache.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/drive/file_cache_metadata.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/drive/file_cache_unittest.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/wallpaper_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/app_pack_updater.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/component_updater/pepper_flash_component_installer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/component_updater/swiftshader_component_installer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/component_updater/widevine_cdm_component_installer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/serial/serial_port_enumerator_posix.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/storage/settings_backend.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/extensions/external_pref_loader.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/extensions/sandboxed_unpacker_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/file_select_helper.cc View 2 chunks +1 line, -2 lines 0 comments Download
MM trunk/src/chrome/browser/history/expire_history_backend.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/history/text_database_manager.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/importer/firefox2_importer.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/importer/firefox3_importer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/importer/ie_importer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/policy/config_dir_policy_loader.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/policy/policy_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/printing/printing_layout_browsertest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_manager.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_shortcut_manager_win.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/shell_integration_win.cc View 2 chunks +2 lines, -3 lines 0 comments Download
MM trunk/src/chrome/browser/ui/pdf/pdf_browsertest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 3 chunks +14 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/feedback_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/common/extensions/api/i18n/default_locale_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/common/extensions/extension_file_util.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M trunk/src/chrome/common/extensions/extension_l10n_util.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/common/extensions/unpacker.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/installer/setup/setup_util.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/chrome/installer/setup/uninstall.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M trunk/src/chrome/installer/test/alternate_version_generator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/installer/util/delete_after_reboot_helper.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/installer/util/duplicate_tree_detector.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/installer/util/installer_state.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/installer/util/installer_state_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/installer/util/shell_util.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/installer/util/shell_util_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome/test/automation/proxy_launcher.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/chrome/zip.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/test/chromedriver/util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/test/gpu/gpu_pixel_browsertest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/test/mini_installer_test/installer_path_provider.cc View 7 chunks +24 lines, -13 lines 0 comments Download
M trunk/src/chrome/test/perf/page_cycler_test.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/test/perf/startup_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/test/reliability/automated_ui_tests.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/test/reliability/page_load_test.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M trunk/src/chrome/test/ui/ui_test.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M trunk/src/chrome/test/webdriver/webdriver_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/tools/profiles/generate_profile.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/chrome_frame/test/reliability/page_load_test.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M trunk/src/cloud_print/virtual_driver/win/virtual_driver.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/components/autofill/browser/data_driven_test.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/content/browser/gpu/gpu_pixel_browsertest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/content/browser/indexed_db/indexed_db_context_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_flash_file_message_filter.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/content/browser/storage_partition_impl_map.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M trunk/src/content/browser/zygote_host/zygote_host_impl_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/gpu/gpu_info_collector_win.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/content/test/image_decoder_test.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/gpu/tools/compositor_model_bench/compositor_model_bench.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/media/video/capture/linux/video_capture_device_linux.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/net/base/directory_lister.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/net/base/directory_lister.cc View 3 chunks +28 lines, -16 lines 0 comments Download
M trunk/src/net/base/directory_lister_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M trunk/src/net/disk_cache/block_files_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M trunk/src/net/disk_cache/cache_util_posix.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/net/disk_cache/simple/simple_index.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M trunk/src/net/tools/dump_cache/dump_files.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/net/tools/quic/quic_in_memory_cache.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/net/url_request/url_request_file_dir_job.cc View 1 chunk +18 lines, -8 lines 0 comments Download
M trunk/src/remoting/host/policy_hack/policy_watcher_linux.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/third_party/leveldatabase/env_chromium.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/third_party/zlib/google/zip.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/third_party/zlib/google/zip_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/tools/android/md5sum/md5sum.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/tools/heapcheck/suppressions.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/tools/valgrind/tsan/suppressions.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/webkit/database/database_tracker.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/webkit/dom_storage/dom_storage_context.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M trunk/src/webkit/fileapi/file_system_database_test_helper.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M trunk/src/webkit/fileapi/file_system_directory_database.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M trunk/src/webkit/fileapi/file_system_origin_database.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/webkit/fileapi/isolated_file_util_unittest.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M trunk/src/webkit/fileapi/local_file_util.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/webkit/fileapi/native_file_util.cc View 3 chunks +8 lines, -8 lines 0 comments Download
MM trunk/src/webkit/plugins/npapi/plugin_list_mac.mm View 2 chunks +3 lines, -4 lines 0 comments Download
MM trunk/src/webkit/plugins/npapi/plugin_list_posix.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dan Beam
7 years, 7 months ago (2013-05-08 05:45:11 UTC) #1
Dan Beam
7 years, 7 months ago (2013-05-08 05:46:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r198850 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698