Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Side by Side Diff: trunk/src/webkit/fileapi/local_file_util.cc

Issue 14824006: Revert 198820 "Move FileEnumerator to its own file, do some refa..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "webkit/fileapi/local_file_util.h" 5 #include "webkit/fileapi/local_file_util.h"
6 6
7 #include "base/files/file_enumerator.h"
8 #include "base/files/file_util_proxy.h" 7 #include "base/files/file_util_proxy.h"
9 #include "googleurl/src/gurl.h" 8 #include "googleurl/src/gurl.h"
10 #include "webkit/fileapi/file_system_context.h" 9 #include "webkit/fileapi/file_system_context.h"
11 #include "webkit/fileapi/file_system_mount_point_provider.h" 10 #include "webkit/fileapi/file_system_mount_point_provider.h"
12 #include "webkit/fileapi/file_system_operation_context.h" 11 #include "webkit/fileapi/file_system_operation_context.h"
13 #include "webkit/fileapi/file_system_types.h" 12 #include "webkit/fileapi/file_system_types.h"
14 #include "webkit/fileapi/file_system_url.h" 13 #include "webkit/fileapi/file_system_url.h"
15 #include "webkit/fileapi/file_system_util.h" 14 #include "webkit/fileapi/file_system_util.h"
16 #include "webkit/fileapi/native_file_util.h" 15 #include "webkit/fileapi/native_file_util.h"
17 16
(...skipping 15 matching lines...) Expand all
33 } 32 }
34 33
35 virtual ~LocalFileEnumerator() {} 34 virtual ~LocalFileEnumerator() {}
36 35
37 virtual base::FilePath Next() OVERRIDE; 36 virtual base::FilePath Next() OVERRIDE;
38 virtual int64 Size() OVERRIDE; 37 virtual int64 Size() OVERRIDE;
39 virtual base::Time LastModifiedTime() OVERRIDE; 38 virtual base::Time LastModifiedTime() OVERRIDE;
40 virtual bool IsDirectory() OVERRIDE; 39 virtual bool IsDirectory() OVERRIDE;
41 40
42 private: 41 private:
43 base::FileEnumerator file_enum_; 42 file_util::FileEnumerator file_enum_;
44 base::FileEnumerator::FileInfo file_util_info_; 43 file_util::FileEnumerator::FindInfo file_util_info_;
45 base::FilePath platform_root_path_; 44 base::FilePath platform_root_path_;
46 base::FilePath virtual_root_path_; 45 base::FilePath virtual_root_path_;
47 }; 46 };
48 47
49 base::FilePath LocalFileEnumerator::Next() { 48 base::FilePath LocalFileEnumerator::Next() {
50 base::FilePath next = file_enum_.Next(); 49 base::FilePath next = file_enum_.Next();
51 // Don't return symlinks. 50 // Don't return symlinks.
52 while (!next.empty() && file_util::IsLink(next)) 51 while (!next.empty() && file_util::IsLink(next))
53 next = file_enum_.Next(); 52 next = file_enum_.Next();
54 if (next.empty()) 53 if (next.empty())
55 return next; 54 return next;
56 file_util_info_ = file_enum_.GetInfo(); 55 file_enum_.GetFindInfo(&file_util_info_);
57 56
58 base::FilePath path; 57 base::FilePath path;
59 platform_root_path_.AppendRelativePath(next, &path); 58 platform_root_path_.AppendRelativePath(next, &path);
60 return virtual_root_path_.Append(path); 59 return virtual_root_path_.Append(path);
61 } 60 }
62 61
63 int64 LocalFileEnumerator::Size() { 62 int64 LocalFileEnumerator::Size() {
64 return file_util_info_.GetSize(); 63 return file_util::FileEnumerator::GetFilesize(file_util_info_);
65 } 64 }
66 65
67 base::Time LocalFileEnumerator::LastModifiedTime() { 66 base::Time LocalFileEnumerator::LastModifiedTime() {
68 return file_util_info_.GetLastModifiedTime(); 67 return file_util::FileEnumerator::GetLastModifiedTime(file_util_info_);
69 } 68 }
70 69
71 bool LocalFileEnumerator::IsDirectory() { 70 bool LocalFileEnumerator::IsDirectory() {
72 return file_util_info_.IsDirectory(); 71 return file_util::FileEnumerator::IsDirectory(file_util_info_);
73 } 72 }
74 73
75 LocalFileUtil::LocalFileUtil() { 74 LocalFileUtil::LocalFileUtil() {
76 } 75 }
77 76
78 LocalFileUtil::~LocalFileUtil() { 77 LocalFileUtil::~LocalFileUtil() {
79 } 78 }
80 79
81 PlatformFileError LocalFileUtil::CreateOrOpen( 80 PlatformFileError LocalFileUtil::CreateOrOpen(
82 FileSystemOperationContext* context, 81 FileSystemOperationContext* context,
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 FileSystemOperationContext* context, 144 FileSystemOperationContext* context,
146 const FileSystemURL& root_url) { 145 const FileSystemURL& root_url) {
147 base::FilePath file_path; 146 base::FilePath file_path;
148 if (GetLocalFilePath(context, root_url, &file_path) != 147 if (GetLocalFilePath(context, root_url, &file_path) !=
149 base::PLATFORM_FILE_OK) { 148 base::PLATFORM_FILE_OK) {
150 return make_scoped_ptr(new EmptyFileEnumerator) 149 return make_scoped_ptr(new EmptyFileEnumerator)
151 .PassAs<FileSystemFileUtil::AbstractFileEnumerator>(); 150 .PassAs<FileSystemFileUtil::AbstractFileEnumerator>();
152 } 151 }
153 return make_scoped_ptr(new LocalFileEnumerator( 152 return make_scoped_ptr(new LocalFileEnumerator(
154 file_path, root_url.path(), 153 file_path, root_url.path(),
155 base::FileEnumerator::FILES | base::FileEnumerator::DIRECTORIES)) 154 file_util::FileEnumerator::FILES |
155 file_util::FileEnumerator::DIRECTORIES))
156 .PassAs<FileSystemFileUtil::AbstractFileEnumerator>(); 156 .PassAs<FileSystemFileUtil::AbstractFileEnumerator>();
157 } 157 }
158 158
159 PlatformFileError LocalFileUtil::GetLocalFilePath( 159 PlatformFileError LocalFileUtil::GetLocalFilePath(
160 FileSystemOperationContext* context, 160 FileSystemOperationContext* context,
161 const FileSystemURL& url, 161 const FileSystemURL& url,
162 base::FilePath* local_file_path) { 162 base::FilePath* local_file_path) {
163 FileSystemMountPointProvider* provider = 163 FileSystemMountPointProvider* provider =
164 context->file_system_context()->GetMountPointProvider(url.type()); 164 context->file_system_context()->GetMountPointProvider(url.type());
165 DCHECK(provider); 165 DCHECK(provider);
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 base::FilePath* platform_path) { 254 base::FilePath* platform_path) {
255 DCHECK(file_info); 255 DCHECK(file_info);
256 // We're just returning the local file information. 256 // We're just returning the local file information.
257 *error = GetFileInfo(context, url, file_info, platform_path); 257 *error = GetFileInfo(context, url, file_info, platform_path);
258 if (*error == base::PLATFORM_FILE_OK && file_info->is_directory) 258 if (*error == base::PLATFORM_FILE_OK && file_info->is_directory)
259 *error = base::PLATFORM_FILE_ERROR_NOT_A_FILE; 259 *error = base::PLATFORM_FILE_ERROR_NOT_A_FILE;
260 return webkit_blob::ScopedFile(); 260 return webkit_blob::ScopedFile();
261 } 261 }
262 262
263 } // namespace fileapi 263 } // namespace fileapi
OLDNEW
« no previous file with comments | « trunk/src/webkit/fileapi/isolated_file_util_unittest.cc ('k') | trunk/src/webkit/fileapi/native_file_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698