Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: trunk/src/chrome/browser/file_select_helper.cc

Issue 14824006: Revert 198820 "Move FileEnumerator to its own file, do some refa..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/file_select_helper.h" 5 #include "chrome/browser/file_select_helper.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/file_util.h" 10 #include "base/file_util.h"
11 #include "base/files/file_enumerator.h"
12 #include "base/platform_file.h" 11 #include "base/platform_file.h"
13 #include "base/string_util.h" 12 #include "base/string_util.h"
14 #include "base/strings/string_split.h" 13 #include "base/strings/string_split.h"
15 #include "base/utf_string_conversions.h" 14 #include "base/utf_string_conversions.h"
16 #include "chrome/browser/platform_util.h" 15 #include "chrome/browser/platform_util.h"
17 #include "chrome/browser/profiles/profile.h" 16 #include "chrome/browser/profiles/profile.h"
18 #include "chrome/browser/ui/browser.h" 17 #include "chrome/browser/ui/browser.h"
19 #include "chrome/browser/ui/browser_list.h" 18 #include "chrome/browser/ui/browser_list.h"
20 #include "chrome/browser/ui/chrome_select_file_policy.h" 19 #include "chrome/browser/ui/chrome_select_file_policy.h"
21 #include "content/public/browser/browser_thread.h" 20 #include "content/public/browser/browser_thread.h"
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 } 212 }
214 213
215 void FileSelectHelper::OnListFile( 214 void FileSelectHelper::OnListFile(
216 int id, 215 int id,
217 const net::DirectoryLister::DirectoryListerData& data) { 216 const net::DirectoryLister::DirectoryListerData& data) {
218 ActiveDirectoryEnumeration* entry = directory_enumerations_[id]; 217 ActiveDirectoryEnumeration* entry = directory_enumerations_[id];
219 218
220 // Directory upload returns directories via a "." file, so that 219 // Directory upload returns directories via a "." file, so that
221 // empty directories are included. This util call just checks 220 // empty directories are included. This util call just checks
222 // the flags in the structure; there's no file I/O going on. 221 // the flags in the structure; there's no file I/O going on.
223 if (data.info.IsDirectory()) 222 if (file_util::FileEnumerator::IsDirectory(data.info))
224 entry->results_.push_back(data.path.Append(FILE_PATH_LITERAL("."))); 223 entry->results_.push_back(data.path.Append(FILE_PATH_LITERAL(".")));
225 else 224 else
226 entry->results_.push_back(data.path); 225 entry->results_.push_back(data.path);
227 } 226 }
228 227
229 void FileSelectHelper::OnListDone(int id, int error) { 228 void FileSelectHelper::OnListDone(int id, int error) {
230 // This entry needs to be cleaned up when this function is done. 229 // This entry needs to be cleaned up when this function is done.
231 scoped_ptr<ActiveDirectoryEnumeration> entry(directory_enumerations_[id]); 230 scoped_ptr<ActiveDirectoryEnumeration> entry(directory_enumerations_[id]);
232 directory_enumerations_.erase(id); 231 directory_enumerations_.erase(id);
233 if (!entry->rvh_) 232 if (!entry->rvh_)
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
495 // A 1 character accept type will always be invalid (either a "." in the case 494 // A 1 character accept type will always be invalid (either a "." in the case
496 // of an extension or a "/" in the case of a MIME type). 495 // of an extension or a "/" in the case of a MIME type).
497 std::string unused; 496 std::string unused;
498 if (accept_type.length() <= 1 || 497 if (accept_type.length() <= 1 ||
499 StringToLowerASCII(accept_type) != accept_type || 498 StringToLowerASCII(accept_type) != accept_type ||
500 TrimWhitespaceASCII(accept_type, TRIM_ALL, &unused) != TRIM_NONE) { 499 TrimWhitespaceASCII(accept_type, TRIM_ALL, &unused) != TRIM_NONE) {
501 return false; 500 return false;
502 } 501 }
503 return true; 502 return true;
504 } 503 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698