Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: trunk/src/net/url_request/url_request_file_dir_job.cc

Issue 14824006: Revert 198820 "Move FileEnumerator to its own file, do some refa..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/net/url_request/url_request_file_dir_job.cc
===================================================================
--- trunk/src/net/url_request/url_request_file_dir_job.cc (revision 198849)
+++ trunk/src/net/url_request/url_request_file_dir_job.cc (working copy)
@@ -116,17 +116,27 @@
}
#if defined(OS_WIN)
- std::string raw_bytes; // Empty on Windows means UTF-8 encoded name.
+ int64 size = (static_cast<unsigned __int64>(data.info.nFileSizeHigh) << 32) |
+ data.info.nFileSizeLow;
+
+ // Note that we should not convert ftLastWriteTime to the local time because
+ // ICU's datetime formatting APIs expect time in UTC and take into account
+ // the timezone before formatting.
+ data_.append(GetDirectoryListingEntry(
+ data.info.cFileName,
+ std::string(),
+ ((data.info.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) != 0),
+ size,
+ base::Time::FromFileTime(data.info.ftLastWriteTime)));
#elif defined(OS_POSIX)
// TOOD(jungshik): The same issue as for the directory name.
- const std::string& raw_bytes = data.info.GetName().value();
+ data_.append(GetDirectoryListingEntry(
+ WideToUTF16(base::SysNativeMBToWide(data.info.filename)),
+ data.info.filename,
+ S_ISDIR(data.info.stat.st_mode),
+ data.info.stat.st_size,
+ base::Time::FromTimeT(data.info.stat.st_mtime)));
#endif
- data_.append(GetDirectoryListingEntry(
- data.info.GetName().LossyDisplayName(),
- raw_bytes,
- data.info.IsDirectory(),
- data.info.GetSize(),
- data.info.GetLastModifiedTime()));
// TODO(darin): coalesce more?
CompleteRead();
« no previous file with comments | « trunk/src/net/tools/quic/quic_in_memory_cache.cc ('k') | trunk/src/remoting/host/policy_hack/policy_watcher_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698