Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1477433005: Remove kuint8max. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
CC:
chromium-reviews, tim+watch_chromium.org, tapted, feature-media-reviews_chromium.org, maxbogue+watch_chromium.org, yusukes+watch_chromium.org, zea+watch_chromium.org, vmpstr+watch_chromium.org, binji+watch_chromium.org, tfarina, tzik, cbentzel+watch_chromium.org, eme-reviews_chromium.org, Matt Giuca, teravest+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, oshima+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, davemoore+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@kint4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove kuint8max. BUG=138542 Committed: https://crrev.com/76490fdfedb1d68f2efd8701e5e70c8a4e3ab753 Cr-Commit-Position: refs/heads/master@{#362982}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Total comments: 6

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -83 lines) Patch
M base/basictypes.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/display/overscan_calibrator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/display/overscan_calibrator.cc View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
M media/cdm/ppapi/cdm_file_io_test.h View 5 chunks +13 lines, -6 lines 0 comments Download
M media/cdm/ppapi/cdm_file_io_test.cc View 4 chunks +16 lines, -13 lines 0 comments Download
M net/quic/quic_http_utils_test.cc View 2 chunks +5 lines, -1 line 0 comments Download
M net/spdy/spdy_http_utils_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M sync/internal_api/public/base/node_ordinal.h View 3 chunks +6 lines, -5 lines 0 comments Download
M sync/internal_api/public/base/ordinal_unittest.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M sync/internal_api/public/base/unique_position.h View 3 chunks +8 lines, -6 lines 0 comments Download
M sync/internal_api/public/base/unique_position.cc View 12 chunks +40 lines, -35 lines 0 comments Download
M ui/app_list/views/speech_view.cc View 3 chunks +7 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 35 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477433005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477433005/1
5 years ago (2015-11-25 15:53:40 UTC) #2
Avi (use Gerrit)
mark: base stevenjb: chrome/browser/chromeos, ui/app_list dalecurtis: media/ mmenke: net/ zea: sync/
5 years ago (2015-11-25 17:00:56 UTC) #4
Mark Mentovai
LGTM
5 years ago (2015-11-25 17:05:02 UTC) #5
stevenjb
c/b/chromeos lgtm https://codereview.chromium.org/1477433005/diff/1/chrome/browser/chromeos/display/overscan_calibrator.cc File chrome/browser/chromeos/display/overscan_calibrator.cc (right): https://codereview.chromium.org/1477433005/diff/1/chrome/browser/chromeos/display/overscan_calibrator.cc#newcode8 chrome/browser/chromeos/display/overscan_calibrator.cc:8: nit: no WS here?
5 years ago (2015-11-25 17:10:43 UTC) #6
mmenke
net/ LGTM
5 years ago (2015-11-25 17:13:33 UTC) #7
DaleCurtis
media/ lgtm
5 years ago (2015-11-25 17:15:46 UTC) #8
Avi (use Gerrit)
https://codereview.chromium.org/1477433005/diff/1/chrome/browser/chromeos/display/overscan_calibrator.cc File chrome/browser/chromeos/display/overscan_calibrator.cc (right): https://codereview.chromium.org/1477433005/diff/1/chrome/browser/chromeos/display/overscan_calibrator.cc#newcode8 chrome/browser/chromeos/display/overscan_calibrator.cc:8: On 2015/11/25 17:10:43, stevenjb wrote: > nit: no WS ...
5 years ago (2015-11-25 17:17:02 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/101333)
5 years ago (2015-11-25 19:22:06 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477433005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477433005/20001
5 years ago (2015-11-25 21:37:38 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ...
5 years ago (2015-11-25 23:43:27 UTC) #15
Nicolas Zea
sync LGTM with some nits https://codereview.chromium.org/1477433005/diff/20001/sync/internal_api/public/base/ordinal_unittest.cc File sync/internal_api/public/base/ordinal_unittest.cc (right): https://codereview.chromium.org/1477433005/diff/20001/sync/internal_api/public/base/ordinal_unittest.cc#newcode7 sync/internal_api/public/base/ordinal_unittest.cc:7: #include <stdint.h> nit: move ...
5 years ago (2015-11-30 17:58:41 UTC) #16
Nicolas Zea
sync LGTM with some nits https://codereview.chromium.org/1477433005/diff/20001/sync/internal_api/public/base/ordinal_unittest.cc File sync/internal_api/public/base/ordinal_unittest.cc (right): https://codereview.chromium.org/1477433005/diff/20001/sync/internal_api/public/base/ordinal_unittest.cc#newcode7 sync/internal_api/public/base/ordinal_unittest.cc:7: #include <stdint.h> nit: move ...
5 years ago (2015-11-30 17:58:41 UTC) #17
Avi (use Gerrit)
https://codereview.chromium.org/1477433005/diff/20001/sync/internal_api/public/base/ordinal_unittest.cc File sync/internal_api/public/base/ordinal_unittest.cc (right): https://codereview.chromium.org/1477433005/diff/20001/sync/internal_api/public/base/ordinal_unittest.cc#newcode7 sync/internal_api/public/base/ordinal_unittest.cc:7: #include <stdint.h> On 2015/11/30 17:58:41, Nicolas Zea wrote: > ...
5 years ago (2015-11-30 18:07:08 UTC) #18
mmenke
https://codereview.chromium.org/1477433005/diff/20001/sync/internal_api/public/base/ordinal_unittest.cc File sync/internal_api/public/base/ordinal_unittest.cc (right): https://codereview.chromium.org/1477433005/diff/20001/sync/internal_api/public/base/ordinal_unittest.cc#newcode7 sync/internal_api/public/base/ordinal_unittest.cc:7: #include <stdint.h> On 2015/11/30 18:07:08, Avi wrote: > On ...
5 years ago (2015-11-30 18:09:52 UTC) #19
Nicolas Zea
https://codereview.chromium.org/1477433005/diff/20001/sync/internal_api/public/base/ordinal_unittest.cc File sync/internal_api/public/base/ordinal_unittest.cc (right): https://codereview.chromium.org/1477433005/diff/20001/sync/internal_api/public/base/ordinal_unittest.cc#newcode7 sync/internal_api/public/base/ordinal_unittest.cc:7: #include <stdint.h> On 2015/11/30 18:09:52, mmenke wrote: > On ...
5 years ago (2015-11-30 23:59:58 UTC) #20
Avi (use Gerrit)
On 2015/11/30 23:59:58, Nicolas Zea wrote: > https://codereview.chromium.org/1477433005/diff/20001/sync/internal_api/public/base/ordinal_unittest.cc > File sync/internal_api/public/base/ordinal_unittest.cc (right): > > https://codereview.chromium.org/1477433005/diff/20001/sync/internal_api/public/base/ordinal_unittest.cc#newcode7 ...
5 years ago (2015-12-01 14:59:07 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477433005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477433005/40001
5 years ago (2015-12-02 00:33:09 UTC) #23
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 02:52:47 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477433005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477433005/60001
5 years ago (2015-12-02 17:16:43 UTC) #27
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-02 21:08:20 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477433005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477433005/60001
5 years ago (2015-12-03 15:34:20 UTC) #32
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-03 15:41:33 UTC) #33
commit-bot: I haz the power
5 years ago (2015-12-03 15:42:43 UTC) #35
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/76490fdfedb1d68f2efd8701e5e70c8a4e3ab753
Cr-Commit-Position: refs/heads/master@{#362982}

Powered by Google App Engine
This is Rietveld 408576698