Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: sync/internal_api/public/base/node_ordinal.h

Issue 1477433005: Remove kuint8max. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@kint4
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/spdy_http_utils_unittest.cc ('k') | sync/internal_api/public/base/ordinal_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SYNC_INTERNAL_API_PUBLIC_BASE_NODE_ORDINAL_H_ 5 #ifndef SYNC_INTERNAL_API_PUBLIC_BASE_NODE_ORDINAL_H_
6 #define SYNC_INTERNAL_API_PUBLIC_BASE_NODE_ORDINAL_H_ 6 #define SYNC_INTERNAL_API_PUBLIC_BASE_NODE_ORDINAL_H_
7 7
8 #include "base/basictypes.h" 8 #include <stdint.h>
9
9 #include "sync/base/sync_export.h" 10 #include "sync/base/sync_export.h"
10 #include "sync/internal_api/public/base/ordinal.h" 11 #include "sync/internal_api/public/base/ordinal.h"
11 12
12 namespace syncer { 13 namespace syncer {
13 14
14 // A NodeOrdinal is an Ordinal whose internal value comes from the 15 // A NodeOrdinal is an Ordinal whose internal value comes from the
15 // ordinal_in_parent field of SyncEntity (see sync.proto). It uses 16 // ordinal_in_parent field of SyncEntity (see sync.proto). It uses
16 // the entire uint8 range for backwards compatibility with the old 17 // the entire uint8_t range for backwards compatibility with the old
17 // int64-based positioning. 18 // int64-based positioning.
18 19
19 struct NodeOrdinalTraits { 20 struct NodeOrdinalTraits {
20 static const uint8 kZeroDigit = 0; 21 static const uint8_t kZeroDigit = 0;
21 static const uint8 kMaxDigit = kuint8max; 22 static const uint8_t kMaxDigit = UINT8_MAX;
22 static const size_t kMinLength = 8; 23 static const size_t kMinLength = 8;
23 }; 24 };
24 25
25 typedef Ordinal<NodeOrdinalTraits> NodeOrdinal; 26 typedef Ordinal<NodeOrdinalTraits> NodeOrdinal;
26 27
27 static_assert(static_cast<char>(NodeOrdinal::kZeroDigit) == '\x00', 28 static_assert(static_cast<char>(NodeOrdinal::kZeroDigit) == '\x00',
28 "NodeOrdinal has incorrect zero digit"); 29 "NodeOrdinal has incorrect zero digit");
29 static_assert(static_cast<char>(NodeOrdinal::kOneDigit) == '\x01', 30 static_assert(static_cast<char>(NodeOrdinal::kOneDigit) == '\x01',
30 "NodeOrdinal has incorrect one digit"); 31 "NodeOrdinal has incorrect one digit");
31 static_assert(static_cast<char>(NodeOrdinal::kMidDigit) == '\x80', 32 static_assert(static_cast<char>(NodeOrdinal::kMidDigit) == '\x80',
32 "NodeOrdinal has incorrect mid digit"); 33 "NodeOrdinal has incorrect mid digit");
33 static_assert(static_cast<char>(NodeOrdinal::kMaxDigit) == '\xff', 34 static_assert(static_cast<char>(NodeOrdinal::kMaxDigit) == '\xff',
34 "NodeOrdinal has incorrect max digit"); 35 "NodeOrdinal has incorrect max digit");
35 static_assert(NodeOrdinal::kMidDigitValue == 128, 36 static_assert(NodeOrdinal::kMidDigitValue == 128,
36 "NodeOrdinal has incorrect mid digit value"); 37 "NodeOrdinal has incorrect mid digit value");
37 static_assert(NodeOrdinal::kMaxDigitValue == 255, 38 static_assert(NodeOrdinal::kMaxDigitValue == 255,
38 "NodeOrdinal has incorrect max digit value"); 39 "NodeOrdinal has incorrect max digit value");
39 static_assert(NodeOrdinal::kRadix == 256, 40 static_assert(NodeOrdinal::kRadix == 256,
40 "NodeOrdinal has incorrect radix"); 41 "NodeOrdinal has incorrect radix");
41 42
42 // Converts an int64 position (usually from the position_in_parent 43 // Converts an int64 position (usually from the position_in_parent
43 // field of SyncEntity) to a NodeOrdinal. This transformation 44 // field of SyncEntity) to a NodeOrdinal. This transformation
44 // preserves the ordering relation: a < b under integer ordering if 45 // preserves the ordering relation: a < b under integer ordering if
45 // and only if Int64ToNodeOrdinal(a) < Int64ToNodeOrdinal(b). 46 // and only if Int64ToNodeOrdinal(a) < Int64ToNodeOrdinal(b).
46 SYNC_EXPORT_PRIVATE NodeOrdinal Int64ToNodeOrdinal(int64 x); 47 SYNC_EXPORT_PRIVATE NodeOrdinal Int64ToNodeOrdinal(int64_t x);
47 48
48 // The inverse of Int64ToNodeOrdinal. This conversion is, in general, 49 // The inverse of Int64ToNodeOrdinal. This conversion is, in general,
49 // lossy: NodeOrdinals can have arbitrary fidelity, while numeric 50 // lossy: NodeOrdinals can have arbitrary fidelity, while numeric
50 // positions contain only 64 bits of information (in fact, this is the 51 // positions contain only 64 bits of information (in fact, this is the
51 // reason we've moved away from them). 52 // reason we've moved away from them).
52 SYNC_EXPORT_PRIVATE int64 NodeOrdinalToInt64(const NodeOrdinal& ordinal); 53 SYNC_EXPORT_PRIVATE int64 NodeOrdinalToInt64(const NodeOrdinal& ordinal);
53 54
54 } // namespace syncer 55 } // namespace syncer
55 56
56 #endif // SYNC_INTERNAL_API_PUBLIC_BASE_NODE_ORDINAL_H_ 57 #endif // SYNC_INTERNAL_API_PUBLIC_BASE_NODE_ORDINAL_H_
OLDNEW
« no previous file with comments | « net/spdy/spdy_http_utils_unittest.cc ('k') | sync/internal_api/public/base/ordinal_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698