Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1471693006: Remove kint32min. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
CC:
chromium-reviews, skanuj+watch_chromium.org, qsr+mojo_chromium.org, vmpstr+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, yzshen+watch_chromium.org, ben+mojo_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, feature-media-reviews_chromium.org, jfweitz+watch_chromium.org, Michael van Ouwerkerk, Jered, donnd+watch_chromium.org, Aaron Boodman, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@kint3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove kint32min. BUG=138542 TBR=jered@chromium.org Committed: https://crrev.com/3ab0ae432ebb0990c783ad8b7216c8f20a9031c7 Cr-Commit-Position: refs/heads/master@{#362811}

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : rebase #

Patch Set 4 : android, rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -124 lines) Patch
M base/android/jni_array_unittest.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download
M base/basictypes.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/instant_restricted_id_cache_unittest.cc View 5 chunks +19 lines, -10 lines 0 comments Download
M content/browser/android/java/gin_java_script_to_java_types_coercion.cc View 1 2 3 4 chunks +14 lines, -9 lines 0 comments Download
M content/browser/geolocation/network_location_request.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/geolocation/network_location_request.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M content/browser/geolocation/wifi_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/geolocation/wifi_data.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M media/blink/buffered_resource_loader.h View 1 2 3 4 5 6 8 chunks +30 lines, -29 lines 0 comments Download
M media/blink/buffered_resource_loader.cc View 10 chunks +28 lines, -25 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair_posix.cc View 2 chunks +5 lines, -1 line 0 comments Download
M net/spdy/spdy_stream.h View 11 chunks +15 lines, -16 lines 0 comments Download
M net/spdy/spdy_stream.cc View 14 chunks +28 lines, -21 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 53 (27 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471693006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471693006/1
5 years ago (2015-11-24 21:24:57 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/149095)
5 years ago (2015-11-24 21:51:58 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471693006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471693006/20001
5 years ago (2015-11-24 22:03:19 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471693006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471693006/40001
5 years ago (2015-11-24 22:34:32 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/113226)
5 years ago (2015-11-24 23:37:18 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471693006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471693006/60001
5 years ago (2015-11-25 15:21:13 UTC) #12
Avi (use Gerrit)
mark: base/ jered: chrome/renderer/ torne: base/android/ and content/browser/android/ mvanouwerkerk: content/browser/geolocation/ dalecurtis: media/ ben: mojo/ mattm: ...
5 years ago (2015-11-25 16:41:02 UTC) #14
Mark Mentovai
LGTM
5 years ago (2015-11-25 16:49:57 UTC) #15
Michael van Ouwerkerk
geolocation lgtm
5 years ago (2015-11-25 16:52:44 UTC) #16
Ben Goodger (Google)
mojo lgtm
5 years ago (2015-11-25 16:54:35 UTC) #17
Torne
android LGTM
5 years ago (2015-11-25 17:03:33 UTC) #18
DaleCurtis
media/ lgtm
5 years ago (2015-11-25 17:15:09 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/101317)
5 years ago (2015-11-25 19:37:01 UTC) #21
mattm
net lgtm
5 years ago (2015-11-25 21:21:35 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471693006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471693006/80001
5 years ago (2015-11-25 21:34:22 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ...
5 years ago (2015-11-25 23:39:40 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471693006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471693006/80001
5 years ago (2015-12-01 16:49:27 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471693006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471693006/80001
5 years ago (2015-12-01 20:52:37 UTC) #33
commit-bot: I haz the power
Failed to apply patch for media/blink/buffered_resource_loader.h: While running git apply --index -3 -p1; error: patch ...
5 years ago (2015-12-01 22:48:38 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471693006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471693006/100001
5 years ago (2015-12-02 00:33:08 UTC) #39
commit-bot: I haz the power
Failed to apply patch for media/blink/buffered_resource_loader.h: While running git apply --index -3 -p1; error: patch ...
5 years ago (2015-12-02 02:50:13 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471693006/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471693006/120001
5 years ago (2015-12-02 17:15:46 UTC) #45
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/148838)
5 years ago (2015-12-02 19:56:28 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471693006/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471693006/120001
5 years ago (2015-12-02 21:13:38 UTC) #49
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years ago (2015-12-02 22:41:48 UTC) #51
commit-bot: I haz the power
5 years ago (2015-12-02 22:45:52 UTC) #53
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/3ab0ae432ebb0990c783ad8b7216c8f20a9031c7
Cr-Commit-Position: refs/heads/master@{#362811}

Powered by Google App Engine
This is Rietveld 408576698